Skip to content

Commit bb88704

Browse files
test: more traiging
1 parent a4733d2 commit bb88704

File tree

2 files changed

+20
-18
lines changed

2 files changed

+20
-18
lines changed

assembly/__spec_tests__/generated.spec.ts

+10-8
Original file line numberDiff line numberDiff line change
@@ -1357,7 +1357,7 @@ xit("line: 1084 - back references are not supported", () => {});
13571357
xit("line: 1085 - back references are not supported", () => {});
13581358
xit("line: 1086 - test encoding issue", () => {});
13591359
xit("line: 1087 - test requires a substring function", () => {});
1360-
xit("line: 1088 - requires triage", () => {});
1360+
xit("line: 1088 - test requires a substring function", () => {});
13611361
it("line: 1089 - matches abc\\x0def\\x00pqr\\x000xyz\\x0000AB against 'abc456 abc\x0def\x00pqr\x000xyz\x0000ABCDE'", () => {
13621362
const match = exec(
13631363
"abc\\x0def\\x00pqr\\x000xyz\\x0000AB",
@@ -1517,9 +1517,9 @@ it("line: 1146 - matches ^[W-c]+$ against 'WXY_^abc'", () => {
15171517
const match = exec("^[W-c]+$", "WXY_^abc", "is");
15181518
expect(match.matches[0]).toBe("WXY_^abc".substring(0, 8));
15191519
});
1520-
xit("line: 1147 - requires triage", () => {});
1521-
xit("line: 1148 - requires triage", () => {});
1522-
xit("line: 1149 - requires triage", () => {});
1520+
xit("line: 1147 - does not support hex notification in character sets", () => {});
1521+
xit("line: 1148 - does not support hex notification in character sets", () => {});
1522+
xit("line: 1149 - does not support hex notification in character sets", () => {});
15231523
xit("line: 1150 - multi line regex not supported yet!", () => {});
15241524
xit("line: 1151 - multi line regex not supported yet!", () => {});
15251525
xit("line: 1152 - multi line regex not supported yet!", () => {});
@@ -1542,7 +1542,7 @@ xit("line: 1159 - multi line regex not supported yet!", () => {});
15421542
xit("line: 1160 - multi line regex not supported yet!", () => {});
15431543
xit("line: 1161 - multi line regex not supported yet!", () => {});
15441544
xit("line: 1162 - multi line regex not supported yet!", () => {});
1545-
xit("line: 1163 - requires triage", () => {});
1545+
xit("line: 1163 - JS does not support the A Z syntax for start and end of string", () => {});
15461546
xit("line: 1164 - multi line regex not supported yet!", () => {});
15471547
xit("line: 1165 - non capturing groups not supported", () => {});
15481548
xit("line: 1166 - non capturing groups not supported", () => {});
@@ -1672,7 +1672,9 @@ xit("line: 1235 - word boundary class not supported yet!", () => {});
16721672
xit("line: 1236 - word boundary class not supported yet!", () => {});
16731673
xit("line: 1237 - word boundary class not supported yet!", () => {});
16741674
xit("line: 1238 - word boundary class not supported yet!", () => {});
1675-
xit("line: 1239 - requires triage", () => {});
1675+
it("line: 1239 - matches ^([^a])([^\\f])([^c]*)([^d]{3,4}) against 'b\fc...'", () => {
1676+
expectNotMatch("^([^a])([^\\f])([^c]*)([^d]{3,4})", ["b\fc..."]);
1677+
});
16761678
it("line: 1240 - matches [^a] against 'Abc'", () => {
16771679
const match = exec("[^a]", "Abc", "s");
16781680
expect(match.matches[0]).toBe("Abc".substring(0, 1));
@@ -2119,7 +2121,7 @@ it("line: 1362 - matches (.*X|^B) against 'BarFoo '", () => {
21192121
expect(match.matches[0]).toBe("BarFoo ".substring(0, 1));
21202122
expect(match.matches[1]).toBe("BarFoo ".substring(0, 1));
21212123
});
2122-
xit("line: 1363 - requires triage", () => {});
2124+
xit("line: 1363 - does not support start of string quantified within an alternation", () => {});
21232125
xit("line: 1364 - multi line regex not supported yet!", () => {});
21242126
xit("line: 1365 - multi line regex not supported yet!", () => {});
21252127
xit("line: 1366 - multi line regex not supported yet!", () => {});
@@ -2133,7 +2135,7 @@ it("line: 1368 - matches (.*X|^B) against 'BarFoo '", () => {
21332135
expect(match.matches[0]).toBe("BarFoo ".substring(0, 1));
21342136
expect(match.matches[1]).toBe("BarFoo ".substring(0, 1));
21352137
});
2136-
xit("line: 1369 - requires triage", () => {});
2138+
xit("line: 1369 - does not support start of string quantified within an alternation", () => {});
21372139
xit("line: 1370 - multi line regex not supported yet!", () => {});
21382140
xit("line: 1371 - multi line regex not supported yet!", () => {});
21392141
xit("line: 1372 - multi line regex not supported yet!", () => {});

spec/test-generator.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ const knownIssues = {
1616
...range(487, 494),
1717
...range(1077, 1082),
1818
],
19+
"does not support start of string quantified within an alternation": [
20+
1363,
21+
1369,
22+
],
23+
"does not support hex notification in character sets": [...range(1147, 1149)],
1924
"lazy quantifiers should still yield the longest overall regex match": [
2025
...range(141, 143),
2126
1288,
@@ -24,18 +29,13 @@ const knownIssues = {
2429
// the test results measure captured groups using character length / locations
2530
// see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/length
2631
// this is tricky to reproduce
27-
"test requires a substring function": [1087],
28-
"requires triage": [
29-
1363,
30-
1369,
32+
"test requires a substring function": [1087, 1088],
33+
"requires triage": [1413, ...range(1301, 1308)],
34+
"test indicates a malformed regex, whereas it appears OK in JS": [1189],
35+
"JS does not support the \\A \\Z syntax for start and end of string": [
3136
1163,
32-
1088,
33-
1239,
34-
...range(1147, 1149),
35-
1413,
36-
...range(1301, 1308),
37+
1164,
3738
],
38-
"test indicates a malformed regex, whereas it appears OK in JS": [1189],
3939
"test regex contains syntax not supported in JS": [82, 1158, 281],
4040
"the test behaviour differs between PCRE and JS": [290],
4141
"test appears to be incorrect?": [203, 204],

0 commit comments

Comments
 (0)