Skip to content

Commit 8c058da

Browse files
test: finished all triage
closes #20
1 parent 12c8e55 commit 8c058da

File tree

2 files changed

+24
-17
lines changed

2 files changed

+24
-17
lines changed

assembly/__spec_tests__/generated.spec.ts

+8-8
Original file line numberDiff line numberDiff line change
@@ -1906,14 +1906,14 @@ it("line: 1299 - matches ^[W-]46] against '[abcd] '", () => {
19061906
it("line: 1300 - matches ^[W-]46] against ']abcd['", () => {
19071907
expectNotMatch("^[W-]46]", ["]abcd["]);
19081908
});
1909-
xit("line: 1301 - requires triage", () => {});
1910-
xit("line: 1302 - requires triage", () => {});
1911-
xit("line: 1303 - requires triage", () => {});
1912-
xit("line: 1304 - requires triage", () => {});
1913-
xit("line: 1305 - requires triage", () => {});
1914-
xit("line: 1306 - requires triage", () => {});
1915-
xit("line: 1307 - requires triage", () => {});
1916-
xit("line: 1308 - requires triage", () => {});
1909+
xit("line: 1301 - does nto support escaped characters in character ranges", () => {});
1910+
xit("line: 1302 - does nto support escaped characters in character ranges", () => {});
1911+
xit("line: 1303 - does nto support escaped characters in character ranges", () => {});
1912+
xit("line: 1304 - does nto support escaped characters in character ranges", () => {});
1913+
xit("line: 1305 - does nto support escaped characters in character ranges", () => {});
1914+
xit("line: 1306 - does nto support escaped characters in character ranges", () => {});
1915+
xit("line: 1307 - does nto support escaped characters in character ranges", () => {});
1916+
xit("line: 1308 - does nto support escaped characters in character ranges", () => {});
19171917
it("line: 1309 - matches ^[W-\\]46] against '-46]789'", () => {
19181918
expectNotMatch("^[W-\\]46]", ["-46]789"]);
19191919
});

spec/test-generator.js

+16-9
Original file line numberDiff line numberDiff line change
@@ -9,36 +9,43 @@ const range = (from, to) =>
99
Array.from({ length: to - from + 1 }, (_, i) => i + from);
1010

1111
const knownIssues = {
12-
"issue with parsing the test itself": [
13-
1103,
14-
...range(1185, 1188),
15-
...range(1095, 1098),
16-
...range(487, 494),
17-
...range(1077, 1082),
18-
],
12+
/* ------- features not yet implemented ------- */
1913
"does not support start of string quantified within an alternation": [
2014
1363,
2115
1369,
2216
],
2317
"does not support hex notification in character sets": [...range(1147, 1149)],
18+
"does nto support escaped characters in character ranges": [
19+
...range(1301, 1308),
20+
],
2421
"lazy quantifiers should still yield the longest overall regex match": [
2522
...range(141, 143),
2623
1288,
2724
],
25+
26+
/* -------- issues with the tests ------------ */
27+
"test appears to be incorrect?": [203, 204],
28+
"issue with parsing the test itself": [
29+
1103,
30+
...range(1185, 1188),
31+
...range(1095, 1098),
32+
...range(487, 494),
33+
...range(1077, 1082),
34+
],
2835
"test contains an octal escape sequence": [1102],
2936
// the test results measure captured groups using character length / locations
3037
// see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/length
3138
// this is tricky to reproduce
3239
"test requires a substring function": [1087, 1088],
33-
"requires triage": [...range(1301, 1308)],
40+
41+
/* -------- differences between PCRE and JS regex ------------ */
3442
"test indicates a malformed regex, whereas it appears OK in JS": [1189],
3543
"JS does not support the \\A \\Z syntax for start and end of string": [
3644
1163,
3745
1164,
3846
],
3947
"test regex contains syntax not supported in JS": [82, 1158, 281],
4048
"the test behaviour differs between PCRE and JS": [290],
41-
"test appears to be incorrect?": [203, 204],
4249
};
4350

4451
const hasKnownIssue = (index) => {

0 commit comments

Comments
 (0)