diff --git a/checkstyle-suppressions.xml b/checkstyle-suppressions.xml index 6f162388c..c8908a729 100644 --- a/checkstyle-suppressions.xml +++ b/checkstyle-suppressions.xml @@ -46,6 +46,9 @@ + - + diff --git a/src/main/java/me/coley/recaf/ui/controls/SplitableTabPane.java b/src/main/java/me/coley/recaf/ui/controls/SplitableTabPane.java index 1afcb9857..13fbe15f9 100644 --- a/src/main/java/me/coley/recaf/ui/controls/SplitableTabPane.java +++ b/src/main/java/me/coley/recaf/ui/controls/SplitableTabPane.java @@ -47,24 +47,6 @@ public SplitableTabPane() { dragEvent.consume(); } }); - setOnDragEntered(dragEvent -> { - Dragboard dragboard = dragEvent.getDragboard(); - if (dragboard.hasString() - && TAB_DRAG_KEY.equals(dragboard.getString()) - && draggedTab.get() != null - && draggedTab.get().getTabPane() != selfPane) { - addStyle(); - } - }); - setOnDragExited(dragEvent -> { - Dragboard dragboard = dragEvent.getDragboard(); - if (dragboard.hasString() - && TAB_DRAG_KEY.equals(dragboard.getString()) - && draggedTab.get() != null - && draggedTab.get().getTabPane() != selfPane) { - removeStyle(); - } - }); // Setup start drag setOnDragDetected(mouseEvent -> { if (mouseEvent.getSource() instanceof TabPane) { @@ -100,8 +82,7 @@ public SplitableTabPane() { if (dragboard.hasString() && TAB_DRAG_KEY.equals(dragboard.getString()) && dragged != null) { - if ( dragged.getTabPane() != selfPane) - { + if (dragged.getTabPane() != selfPane) { SplitableTabPane owner = (SplitableTabPane) dragged.getTabPane(); owner.closeTab(dragged); getTabs().add(dragged); @@ -113,6 +94,25 @@ public SplitableTabPane() { removeStyle(); } }); + // Highlighting with style classes + setOnDragEntered(dragEvent -> { + Dragboard dragboard = dragEvent.getDragboard(); + if (dragboard.hasString() + && TAB_DRAG_KEY.equals(dragboard.getString()) + && draggedTab.get() != null + && draggedTab.get().getTabPane() != selfPane) { + addStyle(); + } + }); + setOnDragExited(dragEvent -> { + Dragboard dragboard = dragEvent.getDragboard(); + if (dragboard.hasString() + && TAB_DRAG_KEY.equals(dragboard.getString()) + && draggedTab.get() != null + && draggedTab.get().getTabPane() != selfPane) { + removeStyle(); + } + }); } /**