Add chord display to score, renders chord patterns directly above each bar of tab staff.

[vivachenx]

Like this picture, Renders chord patterns directly above each bar of tab staff.

Have we considered adding such a rendering method in subsequent versions?

[vivachenx]

[Produj]

May I ask how it was implemented? Thank you very much

[Danielku15]

Hi there.
While it is not directly planned already to be shipped in a dedicated version, I definitely have it on my "known unsupported features" list.
When I implemented it on the top, I made a quick PoC for inline chords and in extreme cases it rather caused troubles in the layouting: #110 (comment)

Theoretically it should be fairly quick to add them again if we want to ignore the extreme cases and live with overlaps in such cases. It would be just a matter of adjusting the ChordEffectInfo to create a ChordDiagramGlyph based on some settings coming from Guitar Pro and/or the some external user input whether to enforce them. Guitar Pro has a setting in the stylesheet which we would respect.

[vivachenx]

Hi there.
Thank you so much for your reply, I just briefly tried adding this feature. I found that if I directly replace the TextGlyph with the ChordDiagramGlyph instance, the rendering is a bit strange.
Then I found another problem, we currently don't seem to support rendering tempo related information
This is alpha result:

This is guitar pro result:

[vivachenx]

this is my test code:
`import { Beat } from '@src/model/Beat';
import { TextAlign } from '@src/platform/ICanvas';
import { BarRendererBase } from '@src/rendering/BarRendererBase';
import { EffectBarGlyphSizing } from '@src/rendering/EffectBarGlyphSizing';
import { EffectGlyph } from '@src/rendering/glyphs/EffectGlyph';
import { TextGlyph } from '@src/rendering/glyphs/TextGlyph';
import { ChordDiagramGlyph } from '@src/rendering/glyphs/ChordDiagramGlyph';
import { EffectBarRendererInfo } from '@src/rendering/EffectBarRendererInfo';
import { Settings } from '@src/Settings';
import { NotationElement } from '@src/NotationSettings';
import { ChordDiagramContainerGlyph } from '@src/rendering/glyphs/ChordDiagramContainerGlyph';

export class ChordsEffectInfo extends EffectBarRendererInfo {
public get notationElement(): NotationElement {
return NotationElement.EffectChordNames;
}

public get hideOnMultiTrack(): boolean {
    return false;
}

public get canShareBand(): boolean {
    return true;
}

public get sizingMode(): EffectBarGlyphSizing {
    return EffectBarGlyphSizing.SingleOnBeat;
}

public shouldCreateGlyph(settings: Settings, beat: Beat): boolean {
    return beat.hasChord;
}

public createNewGlyph(renderer: BarRendererBase, beat: Beat): EffectGlyph {
    const chordDiagram: ChordDiagramGlyph = new ChordDiagramGlyph(0, 0, beat!.chord);
    return chordDiagram
    // return new TextGlyph(0, 0, beat.chord!.name, renderer.resources.effectFont, TextAlign.Center);
}

public canExpand(from: Beat, to: Beat): boolean {
    return false;
}

}
`