Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wrap text in an <h2> #270

Open
terrill opened this issue Nov 17, 2021 · 2 comments
Open

Don't wrap text in an <h2> #270

terrill opened this issue Nov 17, 2021 · 2 comments
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project

Comments

@terrill
Copy link

terrill commented Nov 17, 2021

When entering text in the rich text editor, it automatically adds all the HTML we need (<p>,<ul> or <ol>, etc.).

The plugin then wraps all of that content in an <h2> element, which is invalid HTML. The W3C HTML validator returns errors such as:

  • Element p not allowed as child of element h2 in this context.
  • Element ul not allowed as child of element h2 in this context.

Can the <h2> element be dropped and just use what the rich text editor generates?

If you were to implement this, you could stylize other block level elements using the same default CSS that you're currently using for <h2>. So unless users have overridden the default CSS, their content will still look the same.

@georgejipa
Copy link
Contributor

georgejipa commented Nov 17, 2021

Hello @terrill,

Thanks for your suggestion. We will address this in a future release.

Until then, you can override the maintenance mode template: https://github.com/andrianvaleanu/WP-Maintenance-Mode/blob/master/views/maintenance.php

--
George

@georgejipa georgejipa added enhancement Request to improve or optimize an existing feature or functionality in the project suggestion labels Nov 17, 2021
@FranzXKohl
Copy link

Hi @georgejipa,

This issue is now 1.5 years old, but still hasn't been fixed, unfortunately...

Any chance that the dev team integrates this in a W3C-valid way? Should be a no-brainer, honestly.

Best regards,
Franz

Hello @terrill,

Thanks for your suggestion. We will address this in a future release.

Until then, you can override the maintenance mode template: https://github.com/andrianvaleanu/WP-Maintenance-Mode/blob/master/views/maintenance.php

-- George

@selul selul removed the suggestion label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project
Projects
None yet
Development

No branches or pull requests

4 participants