Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields appear as required even if they're not #316

Closed
AndreeaCristinaRadacina opened this issue Jul 3, 2024 · 7 comments · Fixed by #318 or #319
Closed

Fields appear as required even if they're not #316

AndreeaCristinaRadacina opened this issue Jul 3, 2024 · 7 comments · Fixed by #318 or #319
Assignees
@girishpanchal30
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. Priority-High Expected resolution time - up to 2 business days. regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@AndreeaCristinaRadacina
Copy link

Description

Users reported that the products using PPOM have errors regarding required fields, even if the fields are not required.

Step-by-step reproduction instructions

  1. Update to the latest version of PPOM

  2. Import the attached CSV (or create a meta group with some not required fields)
    ppom-meta-1719991023.csv

  3. Attach it to a product

  4. Go to the product and don't fill in those not required fields, then try to add to cart

Screenshots, screen recording, code snippet or Help Scout ticket

image image

ref: https://wordpress.org/support/topic/wont-add-to-cart/#post-17863642

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.
@AndreeaCristinaRadacina AndreeaCristinaRadacina added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 3, 2024
@pirate-bot pirate-bot added customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired.. labels Jul 3, 2024
@AndreeaCristinaRadacina
Copy link
Author

+1 https://secure.helpscout.net/conversation/2591053028/418169?viewId=212390

@AndreeaCristinaRadacina
Copy link
Author

+1 https://secure.helpscout.net/conversation/2642020955/424336?viewId=212385

@vytisbulkevicius vytisbulkevicius added the Priority-High Expected resolution time - up to 2 business days. label Jul 3, 2024
@AndreeaCristinaRadacina
Copy link
Author

+1 https://wordpress.org/support/topic/addition-error-in-cart-and-checkout/#post-17865516

@girishpanchal30 girishpanchal30 mentioned this issue Jul 3, 2024
Merged
6 tasks
@girishpanchal30 girishpanchal30 linked a pull request Jul 3, 2024 that will close this issue
Show required field error message if the field is required #318
Merged
6 tasks
@girishpanchal30
Copy link
Contributor

@AndreeaCristinaRadacina I've reviewed this issue and fixed it with this PR #318

@AndreeaCristinaRadacina
Copy link
Author

@girishpanchal30, it's working as expected now. Thank you!

@AndreeaCristinaRadacina
Copy link
Author

+1 https://wordpress.org/support/topic/ppom-dont-add-product-to-the-cart/

@vytisbulkevicius vytisbulkevicius linked a pull request Jul 3, 2024 that will close this issue
Release #319
Merged
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 32.0.24 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 3, 2024
@poonam279 poonam279 mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishpanchal30 girishpanchal30

Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. Priority-High Expected resolution time - up to 2 business days. regression Issue represents a change in behavior from a previous version that is not intended or desired.. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
4 participants
@vytisbulkevicius @pirate-bot @girishpanchal30 @AndreeaCristinaRadacina