Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the file name in the cart #191

Closed
AndreeaCristinaRadacina opened this issue Nov 28, 2023 · 2 comments
Closed

Keep the file name in the cart #191

AndreeaCristinaRadacina opened this issue Nov 28, 2023 · 2 comments
Assignees
@girishpanchal30
Labels
customer report Indicates the request came from a customer. new feature Request for a new feature or functionality to be added to the project. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Milestone
v33.0.0

Comments

@AndreeaCristinaRadacina
Copy link

What problem does this address?

A user asked if keeping the original file name inside the cart is possible.

Ref: https://secure.helpscout.net/conversation/2415148038/392206?folderId=931544

What is your proposed solution?

Maintain the name of the uploaded file.

Will this feature require documentation? (Optional)

No.
@AndreeaCristinaRadacina AndreeaCristinaRadacina added the new feature Request for a new feature or functionality to be added to the project. label Nov 28, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Nov 28, 2023
@AndreeaCristinaRadacina
Copy link
Author

+1 https://secure.helpscout.net/conversation/2537359225/408260?viewId=212385

@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Aug 26, 2024
@Soare-Robert-Daniel
Copy link
Contributor

We can go with this pattern for saving files:

<original file name>.<random hash>.<file extension>

E.g.:

cat-1.asdf234.png

@selul selul added this to the v33.0.0 milestone Sep 3, 2024
@girishpanchal30 girishpanchal30 mentioned this issue Sep 16, 2024
Merged
6 tasks
@selul selul mentioned this issue Sep 26, 2024
Merged
@selul selul closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@girishpanchal30 girishpanchal30

Labels
customer report Indicates the request came from a customer. new feature Request for a new feature or functionality to be added to the project. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
v33.0.0
Development

No branches or pull requests
5 participants
@selul @Soare-Robert-Daniel @pirate-bot @girishpanchal30 @AndreeaCristinaRadacina