Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: "Advanced Options" on certain charts break #688

Closed
DanyCaissy opened this issue May 4, 2020 · 3 comments
Closed

Gutenberg: "Advanced Options" on certain charts break #688

DanyCaissy opened this issue May 4, 2020 · 3 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Milestone

Comments

@DanyCaissy
Copy link
Contributor

Possibly related to #675

Description:

Clicking "Advanced options" on the block editor, for certain chart types, results in "the block has encountered an error".

This only happens on Timeline and Bubble charts as far as I could reproduce.

How to reproduce:

1- Create a timeline chart and a bubble chart
2- Create a new post
3- Add both charts to the post via gutenberg
4- Click "Advanced options" on the right when the chart is selected

Expected behaviour:

The chart is displayed properly

Current behaviour:

The block breaks: https://i.imgur.com/2OC57l0.png

Reference:

Video reproducing the issue:
advanced-settings.zip

Console Error: https://i.imgur.com/JU8PzYX.png

Technical info

Wordpress Version: 5.4.1
Visualizer Version: 3.4.2 + 1.9.2

@DanyCaissy DanyCaissy added the bug This label could be used to identify issues that are caused by a defect in the product. label May 4, 2020
@DanyCaissy DanyCaissy added this to the 3.4.4 milestone May 4, 2020
@contactashish13 contactashish13 changed the title Block editor - "Advanced Options" on certain charts break Gutenberg: "Advanced Options" on certain charts break May 12, 2020
@contactashish13
Copy link
Contributor

PR #695 addresses this.

@DanyCaissy as suggested in a couple of earlier issues as well, it will be good to compare each setting for every chart between gutenberg and the library. For example, in this issue Bubble Settings was missing from gutenberg. We should aim to fix all these discrepancies in one go under one single issue.

@rodica-andronache
Copy link
Contributor

@contactashish13 if you can please fix the conflicts here #695 I think we can merge it

@contactashish13
Copy link
Contributor

@rodica-andronache done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

No branches or pull requests

3 participants