Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control for animation to start when user scrolls to the chart #1058

Open
AndreeaCristinaRadacina opened this issue Nov 29, 2023 · 4 comments
Labels
customer report Indicates the request came from a customer. doc-needed This issue requires documentation updates or additions once it has been completed. new feature Request for a new feature or functionality to be added to the project.

Comments

@AndreeaCristinaRadacina
Copy link

AndreeaCristinaRadacina commented Nov 29, 2023

What problem does this address?

A user asked about a method for the animation to start when his visitors scroll down to the diagram and see it.

Ref: https://secure.helpscout.net/conversation/2435424329/394729?folderId=212385

What is your proposed solution?

Introduce a new option like "animation start" and have options like:

Will this feature require documentation? (Optional)

Yes, it requires documentation.

@AndreeaCristinaRadacina AndreeaCristinaRadacina added the new feature Request for a new feature or functionality to be added to the project. label Nov 29, 2023
@pirate-bot pirate-bot added customer report Indicates the request came from a customer. doc-needed This issue requires documentation updates or additions once it has been completed. labels Nov 29, 2023
@vytisbulkevicius
Copy link
Contributor

@AndreeaCristinaRadacina but if you have lazy-loading enabled for the chart it will only be rendered when you scroll to it (it's visible) so animation will only start only then. Your suggestion is still valid but for this case the workaround is to use lazy-loading.

So for example:
[visualizer id="1" lazy="yes" class=""]
Instead of:
[visualizer id="18" lazy="no" class=""]
if client is using a shortcode.

@AndreeaCristinaRadacina
Copy link
Author

AndreeaCristinaRadacina commented Nov 30, 2023

@vytisbulkevicius, I tried using lazy loading, but I thought it would be good to have such behavior in-built. Thank you!

@vytisbulkevicius
Copy link
Contributor

I didn't see it suggested to the customer in the HS ticket that's why I shared this workaround 👌

@AndreeaCristinaRadacina
Copy link
Author

Sure, I shared a few minutes ago. Thank you🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer report Indicates the request came from a customer. doc-needed This issue requires documentation updates or additions once it has been completed. new feature Request for a new feature or functionality to be added to the project.
Projects
None yet
Development

No branches or pull requests

3 participants