Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Twitter icon/name #836

Open
AndreeaCristinaRadacina opened this issue Mar 14, 2024 · 4 comments · Fixed by #838
Open

Update Twitter icon/name #836

AndreeaCristinaRadacina opened this issue Mar 14, 2024 · 4 comments · Fixed by #838
Assignees
Labels
customer report Indicates the request came from a customer. new feature Request for a new feature or functionality to be added to the project. Priority-Low Expected resolution time - up to 3 months. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@AndreeaCristinaRadacina
Copy link

AndreeaCristinaRadacina commented Mar 14, 2024

What problem does this address?

A user asked about updating the Twitter icon and name in the social sharing module:
image

https://secure.helpscout.net/conversation/2539624941/409037?viewId=931544

What is your proposed solution?

Update the icon and name.

Will this feature require documentation? (Optional)

None

@AndreeaCristinaRadacina AndreeaCristinaRadacina added the new feature Request for a new feature or functionality to be added to the project. label Mar 14, 2024
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Mar 14, 2024
@vytisbulkevicius vytisbulkevicius added the Priority-Low Expected resolution time - up to 3 months. label Mar 19, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Mar 22, 2024
@Soare-Robert-Daniel
Copy link
Contributor

One problem here is that for the social module, we use this lib https://github.com/ericakfranz/socicon to display the icons. The problem is that lib is not updated anymore, so it does not have the latest icon for X/Twitter.

I suggest using Font Awesome directly. So we will need to remove the deps on Socicon and update FA to the latest version.

@Soare-Robert-Daniel
Copy link
Contributor

One problem here, the latest version of Socicon does not have the new Twitter logo. The FA version is missing some Chinese brands, like Baidu, which we have available to use.

Socicon repo: https://github.com/Ybbet/socicon/tree/main
FA6 brands: https://fontawesome.com/search?o=r&f=brands

Image

@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Mar 25, 2024 that will close this issue
6 tasks
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.10.35 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 26, 2024
@Soare-Robert-Daniel
Copy link
Contributor

[UPDATE] The new X icon has been introduced in the font: Ybbet/socicon#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer report Indicates the request came from a customer. new feature Request for a new feature or functionality to be added to the project. Priority-Low Expected resolution time - up to 3 months. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants