-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes/Improvements to Onboarding #288
Comments
Before I assign the issue for dev work, can you look into this @Codeinwp/design-team and let us know your thoughts? Also, we will need some design help on how you suppose we deal with the 1st (top header) and 4th (logo uploader). |
For the:
Marius suggested:
I also think that having the FULL URL there after you upload image doesn't make sense I suggest showing only the name of the file without full URL as you can't change it there and it's not visible, scrolling in that input to see it full is not user-friendly. Also created as an issue here - https://github.com/Codeinwp/neve-pro-addon/issues/2634 |
1. Improvements to Logo upload flowI worked a bit more on the logo upload UX and I have a more simple flow to propose. Created a prototype to outline how this works. I think it is much simpler. Please review and let me know if it makes more sense. https://www.loom.com/share/0c0b32199c004ffcb877fbf70b4be1b3?sid=d79424dd-d2ce-4ead-9554-e8d440a7811b This screenshot summarises the UI changes needed. 2. Top barI have tried to tweak the top bar by adding some shadow and/or subtle bg color, but in all cases it will interfere with the site preview at some level. My suggestion is to evaluate if we should remove the top header altogether, from the two "previewing" steps. This would neutralise the distraction and focus on the actual preview. Users can navigate to the previous step with the "back" link if needed. I am not sure if the top bar is so crucial that it would justify an interference of this kind. I also added the link for the related Figma Board in the original comment. Let me know your thoughts! |
@JohnPixle it looks good for me. |
@JohnPixle They look great, and thanks for the prototype. |
Thank you both, I also updated the prototype then to reflect the removal of the top bar. Dont hesitate to ping me if you need any help or clarifications at any point! |
Than you, guys for the clarifications. The changes shouldn't take longer than medium. 🚀 |
Hey @JohnPixle, I have a question regarding this raised issue:
Maintaining the same aspect ratio of starter site cards on bigger displays doesn't look that good. Here's the result on a 2133px width screen: I think the container should be limited too after a certain resolution. |
Hey @cristian-ungureanu! Absolutely, I think a max width must be set and additionally the width of the viewport must have an effect on the number of thumbnails per row, if possible. For example, if a larger viewport can fit 4 thumbnails per row, it should do so. In Figma the thumbnails are sized at approx 350 x 420. You think we can set 400px as the max width? Let me know your thoughts |
Limiting the card to 400px will result in a greater gap between elements unless we switch to a flex container ( there is a grid now ). With a flex container, the number of elements per row will be automatically established by the browser and the 400px limitation would work with a disadvantage of not being able to control the left and right margins: https://vertis.d.pr/i/eODFE3 Alternatively, we can keep the aspect ratio from the design ( 0.83 / 1 ), not limiting the card width and either:
|
Ah, I'm sorry @JohnPixle, there is another solution without switching to flex: https://vertis.d.pr/v/pfX3VO. The elements will be at least 400px width. If I limit them to max 400px, we'll have the margin problem again. |
@cristian-ungureanu no worries, thanks for taking an extra look into this. From what I understand this works well for our case, and we stay with the css grid 👍🏻 |
Hey guys, here are the changes that I've made. Let me know what you think: https://vertis.d.pr/v/RQ25Cp @JohnPixle please let me know about the hover color of the buttons and also if the logo implementation looks good ( plus any other feedback, of course ) 🚀 |
@cristian-ungureanu thank you very much, looking great. I just have a couple of tweaks and I think we are good to go. 1. Remove blue outline from elements on focus. 2. Image placeholder size 3. Button Hover 4. Thumbnails grid That's all from my side. Let me know if you need any clarifications at any point, and thanks for taking care of these ✌🏻 |
🎉 This issue has been resolved in version 1.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What problem does this address?
Based on the feedback received, here are things that we need to address in the Onboarding wizard. It should be noted that we can estimate this issue and if the estimate is larger than medium we can split this into multiple smaller issues and proceed.
What is your proposed solution?
Please refer to this comment for the changed design: #288 (comment)
We can ensure that the button always stays in the view (floating on the bottom), and is inclusive of all the screens with similar buttons.
Please refer to this comment for the changed design: #288 (comment)
Related Figma Board
Will this feature require documentation? (Optional)
None
The text was updated successfully, but these errors were encountered: