Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secondary accent color #64

Closed
JohnPixle opened this issue Oct 24, 2023 · 2 comments · Fixed by #65
Closed

Add secondary accent color #64

JohnPixle opened this issue Oct 24, 2023 · 2 comments · Fixed by #65
Assignees
@mghenciu
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Milestone
1.1.0

Comments

@JohnPixle
Copy link
Contributor

Similar to what we did for Neve, we can introduce the addition of a secondary color in our palette. There is an existing PR that migrates Raft's color slugs to the ones that are used from our other themes, so we need to add the secondary color in the form of:

"slug": "ti-accent-secondary",
          "color": "#F5AABC",
          "name": "Secondary Accent"

Let me know if you need any clarifications!
@JohnPixle JohnPixle added this to the 1.1.0 milestone Oct 24, 2023
@mghenciu mghenciu mentioned this issue Oct 31, 2023
Merged
@mghenciu
Copy link
Contributor

The PR is ready
I've asked for a review from Hardeep.

@JohnPixle JohnPixle linked a pull request Nov 3, 2023 that will close this issue
Adds secondary colors in theme.json + each palette #65
Merged
@HardeepAsrani HardeepAsrani mentioned this issue Nov 20, 2023
Merged
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mghenciu mghenciu

Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Adds secondary colors in theme.json + each palette Codeinwp/raft
4 participants
@HardeepAsrani @JohnPixle @mghenciu @pirate-bot