Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Archives template - inherit query from template #107

Closed
JohnPixle opened this issue Feb 8, 2024 · 2 comments
Closed

All Archives template - inherit query from template #107

JohnPixle opened this issue Feb 8, 2024 · 2 comments

Comments

@JohnPixle
Copy link
Contributor

JohnPixle commented Feb 8, 2024

A user reported this through email, and looks like we can fix this easily. The issue is that the query block, should inherit the template query, since it is part of the template. The fix is simple, need to add the "inherit":true in the block's meta. I will make a PR.

📌 UPDATE: Looks like a false alarm, I got confused because I looked at the demo, which had a customised template I was working with, after checking the master files, the query blocks are configured properly I will wait to see if client has any feedback (he was experiencing some issues with the query), and might close this issue.

inherit

@HardeepAsrani
Copy link
Member

It is the case already as you pointed out in your update: https://github.com/Codeinwp/raft/blob/master/templates/archive.html#L19

@JohnPixle
Copy link
Contributor Author

@HardeepAsrani yes, I am closing the issue, sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants