Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(column): add support for tablet width #2328

Closed
wants to merge 1 commit into from
Closed

feat(column): add support for tablet width #2328

wants to merge 1 commit into from

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Aug 6, 2024 •
edited
Loading

Closes https://github.com/Codeinwp/otter-internals/issues/200

Summary

Add custom width support for Section Column

Screenshots

image

Test instructions

  1. Insert a Section Block
  2. Check if you can change the column with for Tablet
  3. MObile should be disabled

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Aug 6, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 6, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 6, 2024 12:28
@pirate-bot
Copy link
Contributor

Plugin build for 8faba35 is ready 🛎️!

@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 263.56 KB 263.62 KB 57 B (0.02%)
Blocks 1.51 MB 1.51 MB 459 B (0.03%)
CSS 93.26 KB 93.31 KB 57 B (0.06%)
Dashboard 203.99 KB 204.04 KB 57 B (0.03%)
Onboarding 153.22 KB 153.28 KB 57 B (0.04%)
Export Import 90.28 KB 90.34 KB 57 B (0.06%)
Pro 365.35 KB 365.4 KB 57 B (0.02%)

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 233.2, firstPaint: 146.15, domContentLoaded: 1556.35, loaded: 1557.1, firstContentfulPaint: 3444.85, firstBlock: 7612.45, type: 12.87, minType: 11.84, maxType: 14.86, typeContainer: 8.98, minTypeContainer: 7.98, maxTypeContainer: 10.87, focus: 35.22, minFocus: 30.86, maxFocus: 41.64, inserterOpen: 22.36, minInserterOpen: 20.05, maxInserterOpen: 27.02, inserterSearch: 0.71, minInserterSearch: 0.58, maxInserterSearch: 0.88, inserterHover: 4.33, minInserterHover: 2.67, maxInserterHover: 23.19, listViewOpen: 150.69, minListViewOpen: 139.78, maxListViewOpen: 163.86

@ineagu
Copy link
Contributor

ineagu commented Aug 6, 2024

not a complete solution as discussed.

@ineagu ineagu closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Soare-Robert-Daniel @pirate-bot @ineagu