Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PHP fatal error #2372

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fixed PHP fatal error #2372

wants to merge 1 commit into from

Conversation

girishpanchal30
Copy link
Contributor

Closes #2371

Summary

In this PR, I’ve addressed and resolved a fatal error that was occurring with PHP 8 for a specific edge case.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 4, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 4, 2024
@girishpanchal30 girishpanchal30 mentioned this pull request Sep 4, 2024
Open
@girishpanchal30 girishpanchal30 linked an issue Sep 4, 2024 that may be closed by this pull request
Some user gets a fatal error #2371
Open
@pirate-bot
Copy link
Contributor

Plugin build for 1e3bdfb is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 270.5, firstPaint: 510.2, domContentLoaded: 1592.2, loaded: 1593.05, firstContentfulPaint: 3609.2, firstBlock: 8146.5, type: 14.18, minType: 12.47, maxType: 16.61, typeContainer: 9.54, minTypeContainer: 7.66, maxTypeContainer: 11.92, focus: 34.8, minFocus: 31.27, maxFocus: 39.85, inserterOpen: 23.12, minInserterOpen: 19.48, maxInserterOpen: 26.81, inserterSearch: 0.88, minInserterSearch: 0.76, maxInserterSearch: 1.04, inserterHover: 3.92, minInserterHover: 2.63, maxInserterHover: 11.58, listViewOpen: 147.92, minListViewOpen: 137.57, maxListViewOpen: 164.3

@rodica-andronache
Copy link

tested and didn't notice any issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soare-Robert-Daniel Soare-Robert-Daniel Soare-Robert-Daniel approved these changes

Assignees
No one assigned
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some user gets a fatal error
4 participants
@girishpanchal30 @pirate-bot @rodica-andronache @Soare-Robert-Daniel