Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otter Contact Form not Saving Changes in Neve FSE Templates/Template Parts #1802

Closed
stefan-cotitosu opened this issue Aug 8, 2023 · 3 comments · Fixed by #1834
Closed

Otter Contact Form not Saving Changes in Neve FSE Templates/Template Parts #1802

stefan-cotitosu opened this issue Aug 8, 2023 · 3 comments · Fixed by #1834
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. medium (1d) - This label is used for issues that can be completed within 1 day or less. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@stefan-cotitosu
Copy link

Description

When you edit any template of template part in Neve FSE by going to WP Dashboard > Appearance > Editor and place the Otter Form Block, select the Contact Form, make changes to the Save Location or Success or Error Message, save the changes, and refresh the page, the changes are not saved.

When we try to make the change again, it doesn't react and the save button is not allowed to be clicked assuming that no change happened.

Step-by-step reproduction instructions

  1. Install Neve FSE theme and Otter Blocks Plugin.
  2. Go to WP Dashboard > Appearance > Editor > Template > Page > Edit the template.
  3. Place Otter Form Block and select contact.
  4. Make changes to the Save Location setting or Success/Error Message and hit Save.
  5. Refresh the page and your save will vanish.
  6. Try making changes again in Form Settings and try clicking the Save button and it will not get clicked.

Screenshots, screen recording, code snippet or Help Scout ticket

Screen Recording: https://share.getcloudapp.com/nOuL48qm

Help Scout Ticket: https://secure.helpscout.net/conversation/2323424663/380740?folderId=212385

Environment info

No response

Is the issue you are reporting a regression

No

@stefan-cotitosu stefan-cotitosu added the bug This label could be used to identify issues that are caused by a defect in the product. label Aug 8, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Aug 8, 2023
@Soare-Robert-Daniel
Copy link
Contributor

⚠️ The problem is that the function for post saving from core/editor is unusable in the FSE Editor.

Also, the store for the editor has no function for unlocking the save.

Snippet code to check: await window.wp.data.dispatch('core/edit-site')

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel Can we do some digging in and check if there any some ways we could trigger a save on FSE saving? Must be some way they detect things are changing?

@Soare-Robert-Daniel Soare-Robert-Daniel added the medium (1d) - This label is used for issues that can be completed within 1 day or less. label Aug 29, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Aug 29, 2023 that will close this issue
9 tasks
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. medium (1d) - This label is used for issues that can be completed within 1 day or less. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants