Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider images not rendered if added in Neve's header #1750

Closed
MarinescuLucia opened this issue Jul 4, 2023 · 3 comments · Fixed by #1906
Closed

Slider images not rendered if added in Neve's header #1750

MarinescuLucia opened this issue Jul 4, 2023 · 3 comments · Fixed by #1906
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@MarinescuLucia
Copy link

Description

A customer reported that when he adds a Slider block in Customizer -> Header -> Header Builder -> Widget Area 1 (for both desktop and mobile view), the images are displayed correctly on desktop, but only a blank area appears on mobile. When I test this on my instance, the images don't appear on desktop, but they do on mobile. There is no error in the Console. He also encounters the issue when he uses a slider from the Smart Slider 3 plugin.

Step-by-step reproduction instructions

  1. Install Neve, Neve Pro and Otter
  2. Go to Customizer -> Header -> Header Builder
  3. Add a Widget Area 1 component
  4. Add a Slider block in that component
  5. Repeat steps 3-4 for mobile view as well
  6. Check the slider images on desktop and mobile

Screenshots, screen recording, code snippet or Help Scout ticket

Desktop view on the client's site:

desktop2

Mobile view on the client's site:

mobile2

Desktop view on my instance:

desktop

Mobile view on my instance:

mobile

Reported here .

Environment info

No response

Is the issue you are reporting a regression

No

@MarinescuLucia MarinescuLucia added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 4, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Jul 4, 2023
@Soare-Robert-Daniel
Copy link
Contributor

@HardeepAsrani, the issue here is that the CSS is not loaded in the frontend.

Here is how it looks in Customizer regarding the presence of the CSS

image

In frontend

image

⚠️ You can see the lack of CSS properties.


ℹ️ Following this idea of lack of CSS. I added other blocks, and you can see the missing CSS files.

image

🔴 To check if this is an issue with Otter, I installed another plugin to see if the same thing happens. And it happens:

image

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel Can we fix it? Given that unlike third-party plugins, Neve and Otter are sister products. 😄

@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants