Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message does not correspond #1705

Closed
AndreeaCristinaRadacina opened this issue Jun 9, 2023 · 4 comments · Fixed by #1817
Closed

Error message does not correspond #1705

AndreeaCristinaRadacina opened this issue Jun 9, 2023 · 4 comments · Fixed by #1817
Assignees
@Soare-Robert-Daniel
Labels
bug This label could be used to identify issues that are caused by a defect in the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@AndreeaCristinaRadacina
Copy link

Description

The error message displayed is not the same as the error message that I configured.

Step-by-step reproduction instructions

  1. Insert and configure a form block.
  2. Open the Submit Messages accordion.
  3. Configure a new error message.

Screenshots, screen recording, code snippet or Help Scout ticket

image

Environment info

No response

Is the issue you are reporting a regression

No
@AndreeaCristinaRadacina AndreeaCristinaRadacina added the bug This label could be used to identify issues that are caused by a defect in the product. label Jun 9, 2023
@AndreeaCristinaRadacina
Copy link
Author

Similar problem with the Success message, only that this appears well in the editor- https://www.loom.com/share/f780734fcab54664a38e9a80fed16e8f

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel Correct me if I'm wrong but that error message is just there as a representation or it's supposed to update?

@Soare-Robert-Daniel
Copy link
Contributor

It is as displayed. But intendent, I forgot to sync with the real message.

otter-blocks/src/blocks/blocks/form/edit.js

Line 986 in 5ab2087

{ __( 'Error. Please try again.', 'otter-blocks' ) }

@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Jun 13, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Aug 16, 2023 that will close this issue
Fix missing submit messages for Form #1817
Merged
9 tasks
@HardeepAsrani
Copy link
Member

Closing in favor of #1804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
bug This label could be used to identify issues that are caused by a defect in the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing submit messages for Form Codeinwp/otter-blocks
3 participants
@HardeepAsrani @Soare-Robert-Daniel @AndreeaCristinaRadacina