Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS is not generated when switching to a FSE theme #1673

Closed
Soare-Robert-Daniel opened this issue May 24, 2023 · 6 comments · Fixed by #1827
Closed

CSS is not generated when switching to a FSE theme #1673

Soare-Robert-Daniel opened this issue May 24, 2023 · 6 comments · Fixed by #1827
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@Soare-Robert-Daniel
Copy link
Contributor

Description

When transferring to an FSE theme, the custom CSS for the Home page (in Pages) is not generated.

Step-by-step reproduction instructions

If you import some content via Template Cloud, you will have content on the Home page then, if you switch to the FSE theme (e.g.: Raft), the editor will put the original content in a Post Content block.

image

If you go to FSE Editor and select the Front Page then view it, you will notice that the custom styling for the original content is missing.

To fix this, go to Pages > Home, where the original content is, and press Update. This will trigger the CSS generation for the page.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

https://pastebin.com/i0f7Scax

Is the issue you are reporting a regression

No

@Soare-Robert-Daniel Soare-Robert-Daniel added the bug This label could be used to identify issues that are caused by a defect in the product. label May 24, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the medium (1d) - This label is used for issues that can be completed within 1 day or less. label Jun 13, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Aug 23, 2023 that will close this issue
9 tasks
@Soare-Robert-Daniel
Copy link
Contributor Author

@HardeepAsrani, I can no longer reproduce this issue.

Do you think that this change #1827 can help with other themes?

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel You can't reproduce it anymore with any themes at all?

@Soare-Robert-Daniel
Copy link
Contributor Author

Everything seems to work fine. I was also tested with Neve FSE.

ℹ️ A problem when testing this behavior is that Starter Sites use neve var CSS, which becomes invalid when you change the theme.

@HardeepAsrani
Copy link
Member

If that's the case then we can close the PR and issue as issue with CSS variables won't be solved anyway. Perhaps maybe @Codeinwp/qa-team can take a look with the current version of WordPress.org to confirm they also aren't able to reproduce the issue?

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel @HardeepAsrani Tested and i also wasn't able to reproduce it. Feel free to close this ✔️

@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. medium (1d) - This label is used for issues that can be completed within 1 day or less. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants