Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit image size breaking retina is confusing #787

Open
ineagu opened this issue Apr 10, 2024 · 1 comment
Open

Limit image size breaking retina is confusing #787

ineagu opened this issue Apr 10, 2024 · 1 comment
Labels
new feature Request for a new feature or functionality to be added to the project.

Comments

@ineagu
Copy link
Contributor

ineagu commented Apr 10, 2024

What problem does this address?

I couldn't understand why images on Codeinwp are not looking great and I have realised this is because retina is disabled. It was hard to detect because in fact, the setting was enabled, just that I noticed after in the fine print of limit image size, which is enabled by default now, that Retina doesn't work with that.

If that setting is coming on by default, I don't think anyone would read through the whole paragraph to see that retina images aren't working, considering they can just enable that before.

https://vertis.d.pr/i/F138SN

What is your proposed solution?

If we want to leave the settings by default as they are now, I suggest that when a user tries to enable retina we alert them that we disabled limit image size setting for that to work.

Also if the image size is disabled and the user enables it while retina is also active, we alert them that we need to disable retina, since those can't function together.

Basically don't let the user believe that they can enable both of them at the same time.

Will this feature require documentation? (Optional)

None

@ineagu ineagu added the new feature Request for a new feature or functionality to be added to the project. label Apr 10, 2024
@kushh23
Copy link

kushh23 commented Apr 10, 2024

We have something similar reported here - #767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request for a new feature or functionality to be added to the project.
Projects
None yet
Development

No branches or pull requests

2 participants