Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image scaling toggle is not affecting the retina visually despite they depend each other #769

Open
selul opened this issue Jan 16, 2024 · 0 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@selul
Copy link
Contributor

selul commented Jan 16, 2024

Description

When scaling is disabled, the retina function becomes ineffective as it relies on the resizing script to determine whether the screen is retina. This limitation is expected.

However, the user interface does not currently indicate that disabling scaling also removes the retina functionality. We could consider marking the retina option as disabled and display a message when image scaling is turned off.

Step-by-step reproduction instructions

  1. Disable image scaling
  2. Enable retina
  3. Check that no dpr is added to the images

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No

@selul selul added the bug This label could be used to identify issues that are caused by a defect in the product. label Jan 16, 2024
@selul selul modified the milestone: 4.0 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

No branches or pull requests

1 participant