Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the button name when a file is selected #678

Open
AndreeaCristinaRadacina opened this issue Sep 22, 2023 · 2 comments
Open

Adjust the button name when a file is selected #678

AndreeaCristinaRadacina opened this issue Sep 22, 2023 · 2 comments

Comments

@AndreeaCristinaRadacina
Copy link

AndreeaCristinaRadacina commented Sep 22, 2023

What problem does this address?

Now that Optimole offers support for various file types in Dashboard, the button's label is not suitable anymore:
image

What is your proposed solution?

Use something more generic, such as "Select File" or "Select Content", etc.

Will this feature require documentation? (Optional)

None

@AndreeaCristinaRadacina AndreeaCristinaRadacina added new feature Request for a new feature or functionality to be added to the project. and removed new feature Request for a new feature or functionality to be added to the project. labels Sep 22, 2023
@abaicus
Copy link
Contributor

abaicus commented Sep 26, 2023

@AndreeaCristinaRadacina Thank you for sharing this concern with us! Indeed, I think that we should probably revise the DAM integration in context with other file types.

My suggestion here would be to disallow the selection of other file types when inserting images by greying out files that aren't images when using the media library modal in an image import. We can either do that or, similarly to how WordPress acts, we can probably not display other file types in this context.

@AndreeaCristinaRadacina
Copy link
Author

AndreeaCristinaRadacina commented Sep 26, 2023

From what I saw, when I add the File block, the Optimole tab is still available, and it displays both images and the other file types (PDF, in this case). Typically, the file type includes images, so it's okay on this side.
But on the Image block, sounds better what you suggested to limit it to images only.

In this way, with a combination of Image and File blocks, the user can take advantage of all Optimole supported formats.
Thank you for checking!

LE: The "problem" with the button label persists on the File block case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants