New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider wp_constrain_dimensions for Limit Image Dimensions with max width/height #676

Open

selul opened this issue Sep 22, 2023 · 0 comments

Labels

Contributor

selul commented Sep 22, 2023

What problem does this address?

Right now seems like we are doing our own scaling procedure to keep the ratio when Limit Image Dimensions with max width/height is on.

What is your proposed solution?

I would suggest wp_constrain_dimensions like we do here https://github.com/Codeinwp/optimole-wp/blob/master/inc/url_replacer.php#L255C46-L255C69

Discovered this while looking on #675

Will this feature require documentation? (Optional)

No.

selul added the new feature label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment