Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate title tag when RankMath is active #53

Closed
stefan-cotitosu opened this issue Jun 29, 2023 · 7 comments · Fixed by #64
Closed

Duplicate title tag when RankMath is active #53

stefan-cotitosu opened this issue Jun 29, 2023 · 7 comments · Fixed by #64
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.

Comments

@stefan-cotitosu
Copy link

Description

When the RankMath plugin is active, the title tag is duplicated in the page source.

Step-by-step reproduction instructions

  1. Install and activate Neve FSE
  2. Install and activate RankMath
  3. Visit the website you are testing on, check the page source, and search for the title - it appears twice

Screenshots, screen recording, code snippet or Help Scout ticket

neve-fse-duplicate-title

Reported here:
https://wordpress.org/support/topic/remove-the-tag-in-the/
https://secure.helpscout.net/conversation/2286660220/375645/

Environment info

No response

Is the issue you are reporting a regression

No

@stefan-cotitosu stefan-cotitosu added the bug This label could be used to identify issues that are caused by a defect in the product. label Jun 29, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Jun 29, 2023
@HardeepAsrani
Copy link
Member

This seems to be an issue with all of our FSE themes, maybe we can remove them all at once? Seems to be due to add_theme_support( 'title-tag' );

@HardeepAsrani
Copy link
Member

AFAIK, Core themes aren't using the add_theme_support in FSE themes.

@stefan-cotitosu
Copy link
Author

@stefan-cotitosu
Copy link
Author

stefan-cotitosu commented Jul 5, 2023

@HardeepAsrani, thank you for sharing a potential solution.

I provided it to the customer and it doesn't work. Also tested it myself and it doesn't work.

Can you please help with another code snippet?

I added the code at the end of the functions.php file of the theme. Should I use the code differently?

@HardeepAsrani
Copy link
Member

@stefan-cotitosu That wasn't for the support. We have that code in Theme and we need to remove for it to work. Sorry if my commend was confusing.

@stefan-cotitosu
Copy link
Author

Ok, sorry for that; my bad, didn't read it carefully.

@preda-bogdan preda-bogdan added the medium (1d) - This label is used for issues that can be completed within 1 day or less. label Jul 17, 2023
@preda-bogdan preda-bogdan added tiny (1h) - This label is used for issues that can be completed in under an hour. and removed medium (1d) - This label is used for issues that can be completed within 1 day or less. labels Jul 25, 2023
@preda-bogdan preda-bogdan linked a pull request Jul 28, 2023 that will close this issue
cristian-ungureanu pushed a commit that referenced this issue Aug 2, 2023
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants