-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More style variation for the Theme Styles, especially the ones visible in the first line #49
Comments
I came here to submit the same issue, glad I found this one. @HardeepAsrani I had discussed this with someone from the Dev Team back when we were building the second batch of FSE themes, and I recall that our control was limited. However I think this issue must be taken care of across all our themes, and I see other theme authors making a better ob on this. What can we do to fix this? UPDATE: I believe that for the background of the card it automatically adds the site bg color, and the "Aa" is also the text color defined. What you guys suggest to display here? Does the Accent Color and Dark BG in the circles look like a good idea? |
@JohnPixle How will it look with the different sets of variants that we have? Will it look better than it currently does overall? I also see an issue with the Header background, it looks nice in the default but if you change the variants it does look a bit out of place. Let me know what you think. |
@HardeepAsrani I am not suggesting to change any color variable or color logic, just the order of the variables as we define them in the code. Our objective is to make the most representative use of the two circles that in the Style thumbnail. What color is being shown in the dots has to do with the order in which it is defined in the code: Right now the accent color is defined at the end: I managed to display the Accent in the circle of the thumbnail however, when I changed the order. Does it make sense now? |
@JohnPixle Thanks, it makes more sense now. |
@JohnPixle I created a PR with the changes you suggested, let me know if the preview is what you expect and if there are other changes required. Thank you! |
@preda-bogdan These look great, thanks for taking care of it 👍🏻 |
Yes, I believe they use the same mechanism to display the preview there. The preview should be the same. |
fix: style preview for editor #49
🎉 This issue has been resolved in version 1.0.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What problem does this address?
I think we can do a better job in terms of colors, since right now it looks like the Palettes are not even different.
Here are some example of Neve FSE vs Raft vs Fork
What is your proposed solution?
I think we can customize the backgrounds a bit, in order to make them looks more distinct compared one to another.
The text was updated successfully, but these errors were encountered: