Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More style variation for the Theme Styles, especially the ones visible in the first line #49

Closed
mghenciu opened this issue Jun 21, 2023 · 9 comments · Fixed by #58
Closed
Assignees
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@mghenciu
Copy link
Contributor

What problem does this address?

I think we can do a better job in terms of colors, since right now it looks like the Palettes are not even different.

Here are some example of Neve FSE vs Raft vs Fork
Screenshot 2023-06-21 at 14 03 31


Screenshot 2023-06-21 at 14 03 57


Screenshot 2023-06-21 at 14 04 11

What is your proposed solution?

I think we can customize the backgrounds a bit, in order to make them looks more distinct compared one to another.

@mghenciu mghenciu added the enhancement Request to improve or optimize an existing feature or functionality in the project label Jun 21, 2023
@mghenciu mghenciu changed the title More style variations for the Theme Styles More style variation for the Theme Styles, especially the ones visible in the first line Jun 21, 2023
@JohnPixle
Copy link
Contributor

JohnPixle commented Jul 6, 2023

I came here to submit the same issue, glad I found this one.

@HardeepAsrani
This does not only happen to the repository, but to the users Site Editor sidebar. We need to show the Accent color in the thumbnail instead of the one we do now (i think it is text color).

I had discussed this with someone from the Dev Team back when we were building the second batch of FSE themes, and I recall that our control was limited. However I think this issue must be taken care of across all our themes, and I see other theme authors making a better ob on this.

What can we do to fix this?
Does this have to do with how we name the colors?
Or the order in which the colors are defined in the code?

UPDATE:
I tried it and it works. It actually depends on the order of the colors in the code.
I placed the Accent color in the third position in the code, and it worked. After that I added Dark BG next.

I believe that for the background of the card it automatically adds the site bg color, and the "Aa" is also the text color defined.

What you guys suggest to display here? Does the Accent Color and Dark BG in the circles look like a good idea?

Screenshot 2023-07-06 at 2 02 03 PM

@HardeepAsrani
Copy link
Member

@JohnPixle How will it look with the different sets of variants that we have? Will it look better than it currently does overall?

I also see an issue with the Header background, it looks nice in the default but if you change the variants it does look a bit out of place. Let me know what you think.

@JohnPixle
Copy link
Contributor

@HardeepAsrani
Hm... I am not sure I understand...

I am not suggesting to change any color variable or color logic, just the order of the variables as we define them in the code.

Our objective is to make the most representative use of the two circles that in the Style thumbnail. What color is being shown in the dots has to do with the order in which it is defined in the code:

Right now the accent color is defined at the end:

Screenshot 2023-07-06 at 3 09 58 PM

I managed to display the Accent in the circle of the thumbnail however, when I changed the order.

Screenshot 2023-07-06 at 3 13 07 PM

Does it make sense now?

@HardeepAsrani
Copy link
Member

@JohnPixle Thanks, it makes more sense now.

@preda-bogdan preda-bogdan added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Jul 17, 2023
preda-bogdan added a commit that referenced this issue Jul 17, 2023
@preda-bogdan preda-bogdan linked a pull request Jul 17, 2023 that will close this issue
@preda-bogdan
Copy link
Contributor

@JohnPixle I created a PR with the changes you suggested, let me know if the preview is what you expect and if there are other changes required. Thank you!

@JohnPixle
Copy link
Contributor

@preda-bogdan These look great, thanks for taking care of it 👍🏻

Screenshot 2023-07-18 at 11 18 28 AM

@mghenciu
Copy link
Contributor Author

Nice work, Bogdan.

I have a quick question about this: will the new changes also apply to the WP Styles preview visible in the repo? (attached below)
Screenshot 2023-07-18 at 12 45 07

Currently on the Neve FSE page, those look quite white, but in the preview you showed above - those look more colourful (and that's very good).

@preda-bogdan
Copy link
Contributor

Yes, I believe they use the same mechanism to display the preview there. The preview should be the same.

cristian-ungureanu pushed a commit that referenced this issue Aug 2, 2023
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 3, 2023
@JohnPixle JohnPixle modified the milestone: 1.1.0 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request to improve or optimize an existing feature or functionality in the project released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants