Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woo commerce minor visual issues #19

Open
2 tasks
mghenciu opened this issue Apr 12, 2023 · 9 comments
Open
2 tasks

Woo commerce minor visual issues #19

mghenciu opened this issue Apr 12, 2023 · 9 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@mghenciu
Copy link
Contributor

I've gathered here a list of issues, visible when using Neve FSE and Woocommerce.
We can leave this for later, maybe take a look on how other themes like Frost are fixing this issues.

  • Cart/Checkout buttons have a default color (instead of using color from Neve Styles)

Screenshot 2023-04-12 at 15 04 57


Screenshot 2023-04-12 at 15 05 25


  • Same on the Products page and Related Products under single product pages, the buttons are not linked to the Neve Colors
    Screenshot 2023-04-12 at 15 07 31

Screenshot 2023-04-12 at 15 08 30

If you noticed something else @JohnPixle , feel free to add them here.


For Buttons I tried this Custom CSS and it worked:

.wp-block-button.wc-block-components-product-button .wc-block-components-product-button__button,
.woocommerce ul.products li.product .button {
background-color:var(--wp--preset--color--ti-accent);
border-radius: var(--neve-button-border-radius, 5px);
border-color: var(--wp--preset--color--ti-accent);
color: var(--wp--preset--color--ti-fg-alt);
    font-size: var(--wp--preset--font-size--normal);
}
@JohnPixle
Copy link
Contributor

@preda-bogdan I think we can close this issue as well.
It's great that we fixed these issues that Mihai spotted, and I suggest we revisit the woocommerce integration after the initial release, I think it needs a more focused review across all aspects. Also, upcoming changes are expected in core, so let's better see if a major change happens soon.

@mghenciu
Copy link
Contributor Author

mghenciu commented May 4, 2023

Do you guys think should we also apply this fixes to the other FSE themes?
I don't think any of them have the Shop buttons style fixed.

@JohnPixle
Copy link
Contributor

@mghenciu That would be a good idea actually, at least to schedule it for a future update on these themes. I say yes.
You think you can create an issue on each theme with a similar request, when you have the time?

@mghenciu
Copy link
Contributor Author

mghenciu commented May 4, 2023

You think you can create an issue on each theme with a similar request, when you have the time?

Sure thing.

@preda-bogdan
Copy link
Contributor

@JohnPixle
cc: @mghenciu
I think we can leave it open for now to reference it and get back to it when we decide to tackle the WooCommerce implementation.

What do you think?

@JohnPixle
Copy link
Contributor

@preda-bogdan makes sense, absolutely.

@vytisbulkevicius vytisbulkevicius added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 4, 2023
@mghenciu
Copy link
Contributor Author

Hey, @Codeinwp/sbs & @JohnPixle , what do you think if we also include this in the next release? since Bogdan already did the changes, a lot of time passed from june, and this issue is just about the Woo Buttons styles - nothing else more complicated.

This is how the buttons looksnow, with a Woo instance and Neve FSE:
Screenshot 2023-08-30 at 17 59 01

@HardeepAsrani
Copy link
Member

@mghenciu Sure, you're talking about doing these changes for Other themes?

@mghenciu
Copy link
Contributor Author

mghenciu commented Sep 1, 2023

you're talking about doing these changes for Other themes?

This screenshots from above are from Neve FSE, the live build.
So I assume the issue with Woo buttons happens on all our FSE themes.

@JohnPixle JohnPixle added this to the 1.1.0 milestone Sep 20, 2023
@JohnPixle JohnPixle removed this from the 1.0.6 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

No branches or pull requests

5 participants