Skip to content

Commit

Permalink
Improve boot of addons
Browse files Browse the repository at this point in the history
  • Loading branch information
SamyPesse committed Nov 11, 2013
1 parent 980ad07 commit 61cd0ba
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 12 deletions.
26 changes: 15 additions & 11 deletions core/cb.addons/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,11 @@ function setup(options, imports, register, app) {
var command = rjs+" -o baseUrl="+addonPath+" paths.require-tools="+requiretoolsPath+" name="+main+" map.*.css=require-tools/css/css map.*.less=require-tools/less/less out="+output;

// Run optimization
logger.log("Optimizing", addon.name, command);
return Q.nfcall(exec, command).fail(function(err) {
logger.log("Optimizing", addon.name);
return Q.nfcall(exec, command).then(function() {
logger.log("Finished", addon.name, "optimization");
return Q(output);
}, function(err) {
logger.error("error for",addon.name);
logger.exception(err, false);
return Q.reject(err);
Expand Down Expand Up @@ -287,18 +290,19 @@ function setup(options, imports, register, app) {
logger.exception(err, false);
}).fin(optimzeClientsAddons).then(function() {
return initNodeAddons()
}).fail(function(err) {
}).then(function() {
logger.log("Addons are ready");
register(null, {
'addons': {
'list': loadAddonsInfos,
'install': installAddon,
'uninstall': uninstallAddon
}
});
}, function(err) {
logger.error("Error with external node addons:");
logger.exception(err);
});

register(null, {
'addons': {
'list': loadAddonsInfos,
'install': installAddon,
'uninstall': uninstallAddon
}
});
};

// Exports
Expand Down
3 changes: 2 additions & 1 deletion core/cb.main/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
"logger",
"server",
"workspace",
"watch"
"watch",
"addons"
]
}
}

0 comments on commit 61cd0ba

Please sign in to comment.