-
-
Notifications
You must be signed in to change notification settings - Fork 67
Include vscode extension file in Module repos #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was under the impression that we already had a collection of extensions somewhere - but I think it needed some manual intervention to install. The other thought I had was a Github Action to run Prettier and fail the build if it doesn't pass - unless we already have this? If that's the case then could we make the error more "obvious" - perhaps post a comment on their PR? |
Aha found it: https://github.com/CodeYourFuture/cyf-extension-pack Looks like we link to it from https://docs.codeyourfuture.io/leaders/joining-the-course/getting-setup#extensions, which is itself linked to from https://curriculum.codeyourfuture.io/guides/code-style-guide/.
|
We do have an extension pack (as linked in the ticket) but the problem is they don't install it. The recommended extensions file prompts them when they open the repo in VSCode. |
I have a bash script to make it fast (which I tested with one repo already). But I can't push to the other repos yet. |
@pseudopilot Thanks for the adding these! I'm wondering when in the curriculum we should ask trainees to explore this fancy new approach and install recommended extensions. We introduce VS Code at a different time to cloning a Git repo. That leaves a backlog task in Sprint 3 which mentions the existing extension pack. Unless there's alternative suggestions, I'll make the edit to the backlog issue and ask trainees to:
P.S.: It's possible to get VS Code to suggest the CYF extensions pack with: {
"recommendations": [
"CodeYourFuture.cyf-extension-pack"
]
} ... however I'm not a fan in this case. It hides what is going on, showing only the extension pack in the Extensions pane, and not each individual extension to be installed. |
@JayMayer , thank you. Honestly I didn't know we could use an extensions pack in recommendation. 😃 Now I know 😎 |
Which module(s) and week(s) does this change affect?
Module(s): all
Week(s): n/a
What is the work that needs to be done?
We spend a lot of time asking/begging/demanding trainees install Prettier and it really annoys me.
We can include a vscode recommended extensions file in their coursework repos to nag them for me.
Why is this work important to do?
Our general recs are
Current recs
Possible additions
Additional context
Who might need to know about this change?
The text was updated successfully, but these errors were encountered: