Skip to content

Include vscode extension file in Module repos #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SallyMcGrath opened this issue Nov 6, 2023 · 7 comments
Closed

Include vscode extension file in Module repos #368

SallyMcGrath opened this issue Nov 6, 2023 · 7 comments
Assignees
Labels
⚙️ good first issue Good for newcomers ITP Work belongs to or is needed for ITP
Milestone

Comments

@SallyMcGrath
Copy link
Member

SallyMcGrath commented Nov 6, 2023

Which module(s) and week(s) does this change affect?
Module(s): all
Week(s): n/a

What is the work that needs to be done?

We spend a lot of time asking/begging/demanding trainees install Prettier and it really annoys me.

We can include a vscode recommended extensions file in their coursework repos to nag them for me.

Why is this work important to do?

Our general recs are

Current recs

Name ID Purpose
Prettier esbenp.prettier-vscode Code formatter - Format your code automatically
ESLint dbaeumer.vscode-eslint Linter - Tells you when your code is wrong
Code Spell Checker streetsidesoftware.code-spell-checker Tells you when you've spelt something wrong
GitLens — Git supercharged eamodio.gitlens Connect with GitHub/Git
Live Server ritwickdey.LiveServer Run your code in the browser
Live Share MS-vsliveshare.vsliveshare Share your project with a team

Possible additions

Additional context

Who might need to know about this change?

@40thieves
Copy link
Contributor

I was under the impression that we already had a collection of extensions somewhere - but I think it needed some manual intervention to install.

The other thought I had was a Github Action to run Prettier and fail the build if it doesn't pass - unless we already have this? If that's the case then could we make the error more "obvious" - perhaps post a comment on their PR?

@40thieves
Copy link
Contributor

40thieves commented Nov 6, 2023

Aha found it: https://github.com/CodeYourFuture/cyf-extension-pack

Looks like we link to it from https://docs.codeyourfuture.io/leaders/joining-the-course/getting-setup#extensions, which is itself linked to from https://curriculum.codeyourfuture.io/guides/code-style-guide/.

Haven't had a poke through the "new" setup though. Ah, linked to from here: https://curriculum.codeyourfuture.io/html-css/prep/

@SallyMcGrath
Copy link
Member Author

We do have an extension pack (as linked in the ticket) but the problem is they don't install it. The recommended extensions file prompts them when they open the repo in VSCode.

@SallyMcGrath SallyMcGrath added this to the ITP milestone Jun 4, 2024
@SallyMcGrath SallyMcGrath added the ITP Work belongs to or is needed for ITP label Jun 4, 2024
@fcaroline2020 fcaroline2020 added the ⚙️ good first issue Good for newcomers label Jul 6, 2024
@fcaroline2020 fcaroline2020 moved this from 📋 Backlog to 🔖 Ready in Curriculum Planning Jul 6, 2024
@pseudopilot pseudopilot moved this from 🔖 Ready to 🏗 In progress in Curriculum Planning Jul 13, 2024
@pseudopilot
Copy link
Contributor

I have a bash script to make it fast (which I tested with one repo already). But I can't push to the other repos yet.
To make me eligible to push my branch to the first repo @illicitonion set ITP team as maintainers of the repo.
Either we need to do it for all the repos or I can just hand the script to anybody who has full access already.

@JayMayer
Copy link
Member

JayMayer commented Jul 16, 2024

@pseudopilot Thanks for the adding these! I'm wondering when in the curriculum we should ask trainees to explore this fancy new approach and install recommended extensions.

We introduce VS Code at a different time to cloning a Git repo. That leaves a backlog task in Sprint 3 which mentions the existing extension pack. Unless there's alternative suggestions, I'll make the edit to the backlog issue and ask trainees to:

  1. In VS Code, open the Extensions pane (View > Extensions)
  2. Search for @recommended in the search bar
  3. Click on the button for "Install Workspace Recommended Extensions" (displayed as download arrow inside a cloud icon)

P.S.: It's possible to get VS Code to suggest the CYF extensions pack with:

{
  "recommendations": [
    "CodeYourFuture.cyf-extension-pack"
  ]
}

... however I'm not a fan in this case. It hides what is going on, showing only the extension pack in the Extensions pane, and not each individual extension to be installed.

@pseudopilot
Copy link
Contributor

@JayMayer , thank you. Honestly I didn't know we could use an extensions pack in recommendation. 😃 Now I know 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ good first issue Good for newcomers ITP Work belongs to or is needed for ITP
Projects
Archived in project
Development

No branches or pull requests

5 participants