Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Improve performance of Find Properties page #854

Open
3 tasks
CodeWritingCow opened this issue Jul 30, 2024 · 5 comments
Open
3 tasks

Task: Improve performance of Find Properties page #854

CodeWritingCow opened this issue Jul 30, 2024 · 5 comments
Assignees
Labels

Comments

@CodeWritingCow
Copy link
Collaborator

Describe the task

Clean and Green Philly's Find Properties page has a Google Lighthouse performance score of 58/100 on mobile devices, and 60/100 on desktop devices. The page's Largest Contenful Paint is taking 6.3 seconds, and the website's logo (https://www.cleanandgreenphilly.org/logo.svg) appears to be causing this.

Reduce this page's image loading time and Improve the score to high 80s or low-to-mid 90s.

Acceptance Criteria

  • Reduce largest contentful paint time by loading images faster
  • Generate Lighthouse report for mobile devices, showing improvement in performance score
  • Post screenshots of results in this issue's comments section

Additional context

@AZBL
Copy link
Contributor

AZBL commented Sep 25, 2024

Can I be assigned this please.

@bacitracin
Copy link
Collaborator

assigned!

@AZBL
Copy link
Contributor

AZBL commented Sep 26, 2024

@CodeWritingCow

I minified the logo svg, but it didn't much improve performance. Interestingly, when I ran the lighthouse report (which I did in an incognito browser with Chrome as well) I got significantly different results compared to #734. The largest contentful paint wasn't that slow to begin with for me, but the total blocking time was much worse, mostly due to main-thread-work, particularly script evaluation. Do you have suggestions for what to try next? For the record I only included screenshots of the report after minifying the logo (using vecta.io) because there was not much of a difference in the scores.

Find Properties Desktop Lighthouse Report

find-prooperties-desktop-after

Desktop Main Thread Work Details

find-properties-desktop-main-thread-work

Find Properties Mobile Lighthouse Report

find-properties-mobile-after

Mobile Main Thread Work Details

find-properties-mobile-main-thread-work

@AZBL
Copy link
Contributor

AZBL commented Sep 26, 2024

@CodeWritingCow
I just realized I was doing that all on my local host as opposed to the production site. I ran it again on the production site and the largest contentful paint was again slower, and the total blocking time was improved but still slow. Of course this is not including the minified logo svg, so I'm not sure how to go about comparing here.

@CodeWritingCow
Copy link
Collaborator Author

CodeWritingCow commented Sep 29, 2024

Hi @AZBL, what is your minified SVG's file size vs the current SVG on the production site? If there's a significant reduction without loss of image quality, can you open a PR to replace the SVG in prod with your minified version? Thanks!

We can run a Lighthouse audit and check if we'd improve performance by using the minified file in prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Development
Development

No branches or pull requests

3 participants