Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vacant Property Count #1013

Open
soskin opened this issue Nov 20, 2024 · 2 comments
Open

Vacant Property Count #1013

soskin opened this issue Nov 20, 2024 · 2 comments

Comments

@soskin
Copy link

soskin commented Nov 20, 2024

When Zooming on Vacant Property Map (using mouse), the total property count varied above 35K (47K, 52K, 67k)
Steps to reproduce the behavior:

  1. Go to www.cleanandgreenphilly.org
  2. Click on "Find Properties"
  3. Use mouse to zoom in/out
  4. See error in Total Property Count ranging on up to 67,097
  5. Have not added any Filters (checked in the moment, when trouble shooting to ensure these were clear)

Would expect count NOT to exceed ~35,227 when looking at the entire map range for Philadelphia.

Screen Shot 2024-11-20 at 10 20 28 AM

macOS 10.15
Chrome

Tried to reproduce at 3:27PM 2024-11-20 and could not, property range came in at 35,227 as expected.

@nlebovits
Copy link
Collaborator

I've seen this happen, and, generally, the changing numbers of properties depending on the zoom level was confusing to people in our workshop. There may be room for a smarter rewrite of this feature to avoid this problem entirely.

However, what I think is happening is that the FE is briefly using both the point and polygon layers of the pmtiles as it switches zoom levels, which is basically doubling the number of observations when toggling between zoom levels. There's probably an easy way to avoid this.

Copy link

This issue has been marked as stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Do
Development

No branches or pull requests

2 participants