Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrate script to pre-deploy #13

Open
DavidTheProgrammer opened this issue Dec 4, 2024 · 5 comments
Open

Add migrate script to pre-deploy #13

DavidTheProgrammer opened this issue Dec 4, 2024 · 5 comments
Assignees

Comments

@DavidTheProgrammer
Copy link

Add a migrate command to the predeploy script to ensure any pending migrations are always run at startup.

@DavidTheProgrammer
Copy link
Author

@kilemensi, @thepsalmist thoughts on this? The deployment had some hiccups because the application didn't run migrations at startup. There's already a predeploy script that runs collectstatic, I'm considering adding a migrate command to it as wel..

@kilemensi
Copy link
Member

My 2 cents would be to keep this as issue for now. We'll pick it up when we discuss the future of the project i.e. lets not make any changes not already in/incompatible with upstream.

I believe migrations can be run manually after you've ssh'ed into the instance/app, right @DavidTheProgrammer ?

@DavidTheProgrammer
Copy link
Author

That's fair, I think we can leave it as an issue for now as advised. We can circle back to it if needed.

Yes, they can. That's how i resolved it this time around. I'll have to remember to do it again when we switch to the final DB

@thepsalmist
Copy link

@DavidTheProgrammer 👍 I see they have a migrate command within the app.json but i'll double also check

@DavidTheProgrammer
Copy link
Author

@DavidTheProgrammer 👍 I see they have a migrate command within the app.json but i'll double also check

Yes, but it's under the "review" section, so I believe it only applies to review apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants