Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker method calling part needs to be refactored #1551

Open
HoOngEe opened this issue May 21, 2019 · 0 comments
Open

Tracker method calling part needs to be refactored #1551

HoOngEe opened this issue May 21, 2019 · 0 comments

Comments

@HoOngEe
Copy link
Contributor

HoOngEe commented May 21, 2019

Now the tracker() method can be called through the structs ShardTransaction, Action and Transaction.

Some caller function code is now using useless conversion from Action to ShardTransaction though the conversion was already implemented inside of the tracker() of Action.
As well as the above, after the pr#1548, the implementations will become inconsistent. Previously the tracker was needed only for asset transactions, but now the WrapCCC needs tracker though it's not an asset transaction.

From this semantic inconsistency, there is an implementation gap between tracker() of Action and the others. Therefore, the refactoring needs for tracker() and related caller functions not to be confused in the future.

@HoOngEe HoOngEe changed the title Tracker method calling part needs to be refactored. Tracker method calling part needs to be refactored Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants