Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go[Newer/Older]AndArchive should not toggle archive, it should set to true #11

Open
hafdon opened this issue Apr 30, 2021 · 1 comment
Open

go[Newer/Older]AndArchive should not toggle archive, it should set to true #11

hafdon opened this issue Apr 30, 2021 · 1 comment

Comments

@hafdon
Copy link

hafdon commented Apr 30, 2021

First, very good courses here, I really find them valuable.

In the course-end branch, in MailView.vue (starting video #10: Flexible Events) , you pass
toggleArchive: true with goNewerAndArchive and goOlderAndArchive. However, those shouldn't toggle the archive value, they should set it to true.

https://github.com/Code-Pop/build-gmail-clone-with-vue-3/blob/course-end/src/components/MailView.vue#L29
@hafdon
Copy link
Author

hafdon commented Apr 30, 2021

Oh I guess ... since you're only able to read un-archived emails then it's not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hafdon