Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action's "new version" message doesn't yield a clickable link #112

Closed
frgfm opened this issue Aug 9, 2024 · 1 comment
Closed

Action's "new version" message doesn't yield a clickable link #112

frgfm opened this issue Aug 9, 2024 · 1 comment

Comments

@frgfm
Copy link

frgfm commented Aug 9, 2024

Hello there 👋

Thanks for the great work! I just tried to add Codspeed to my existing test suite (frgfm/torch-cam#270) and following the documentation, I used the v2 action.

However running the workflow, the GitHub CI runner gives me a warning:

Warning: A new version v3 is available at https://github.com/CodSpeedHQ/action/releases. You're currently using version v2. Please update to the latest version for improved features and bug fixes.
   ______            __ _____                         __
  / ____/____   ____/ // ___/ ____   ___   ___   ____/ /
 / /    / __ \ / __  / \__ \ / __ \ / _ \ / _ \ / __  /
/ /___ / /_/ // /_/ / ___/ // /_/ //  __//  __// /_/ /
\____/ \____/ \__,_/ /____// .___/ \___/ \___/ \__,_/
  https://codspeed.io/     /_/          runner v2.4.3

So I tried to follow the hyperlink, but it's a 404. The only problem is that GitHub workflow makes links clickable, but it takes the period which makes the link invalid

I'll open a PR to update the README of the pytest plugin, and I don't know whether it's worth changing the action console output. But I thought it's better that you know since it can impact how easily people upgrade from v2 to v3

Cheers!

@art049
Copy link
Member

art049 commented Sep 4, 2024

Thanks a lot!

@art049 art049 closed this as completed Sep 4, 2024
art049 added a commit that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants