chore: cleanup & improve networking (#1433)

The current network implementation has some issues that needed to be
addressed. Most noticeble are:
- issues with very high native memory consumption due to netty not
releasing native memory instantly
- issues with a lot of loaded classes that were auto generated
- use of ASM which leads to issues with server implementations
- rpc code generation can be noticeably improved, especially to ease the
usage
- and many places where the old code was just messy and could be
replaced with a cleaner & easier to read version

- bump the required java version for cloudnet to 22 & enable preview
features.
- replace the usages of ASM in code generation with the java classfile
api
- rewrite rpc handling & code generation completely
- improve default values for settings (for example lower thread counts
for packet handling)
- improve chunked data transfer, prevent race conditions when querying
files
- use custom buffer allocator that releases native memory immediately
instead of relying on GC
- higher test coverage
- ... and many more small cleanups and improvements

Improved networking that should ease the use for external users and
definitely decrease the amount of reported errors.

Author: derklaro

.env

@@ -1,3 +1,3 @@
 MEMORY=512
-JAVA_COMPOSE_OPTS=-XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC
+JAVA_COMPOSE_OPTS=-XX:+UseZGC -XX:+PerfDisableSharedMem
 CLOUDNET_COMPOSE_OPTS=

.github/workflows/codeql-analysis.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Setup java
         uses: actions/setup-java@v4
         with:
-          java-version: 21
+          java-version: 22
           check-latest: true
           distribution: 'zulu'
 

.github/workflows/gradle-release.yml

@@ -20,7 +20,7 @@ jobs:
       - name: Setup java
         uses: actions/setup-java@v4
         with:
-          java-version: 21
+          java-version: 22
           check-latest: true
           distribution: 'zulu'
 

.github/workflows/gradle.yml

@@ -16,11 +16,6 @@ jobs:
   build:
     runs-on: ubuntu-latest
     name: Build and publish
-    strategy:
-      fail-fast: false
-      matrix:
-        java:
-          - 21
 
     steps:
       - name: Checkout repository
@@ -32,14 +27,14 @@ jobs:
       - name: Setup java
         uses: actions/setup-java@v4
         with:
+          java-version: 22
           check-latest: true
           distribution: 'zulu'
-          java-version: ${{ matrix.java }}
 
       - name: Setup gradle cache
         uses: gradle/actions/setup-gradle@v3
         with:
-          cache-read-only: ${{ github.ref != 'refs/heads/nightly' || matrix.java != 21 }}
+          cache-read-only: ${{ github.ref != 'refs/heads/nightly' }}
 
       - name: Setup Loom cache
         uses: actions/cache@v4
@@ -52,7 +47,7 @@ jobs:
         run: ./gradlew build test shadowJar genUpdaterInformation --stacktrace
 
       - name: Publish test summary
-        if: ${{ github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') && matrix.java == 21 }}
+        if: ${{ github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') }}
         uses: EnricoMi/publish-unit-test-result-action@v2
         with:
           junit_files: "**/build/test-results/test/TEST-*.xml"
@@ -63,7 +58,7 @@ jobs:
 
       - name: Publish updater metadata
         uses: s0/git-publish-subdir-action@develop
-        if: ${{ github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/renovate/') && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') && matrix.java == 21 }}
+        if: ${{ github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/renovate/') && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') }}
         env:
           REPO: [email protected]:CloudNetService/launchermeta.git
           BRANCH: ${{ steps.branch-name.outputs.current_branch }}
@@ -75,7 +70,6 @@ jobs:
           MESSAGE: 'Update launcher meta for {target-branch} (commit: {sha})'
 
       - name: Set version type in GitHub environment
-        if: ${{ matrix.java == 21 }}
         run: |
           if [ "$(./gradlew properties | awk '/^version:/ { print $2; }' | grep '\-SNAPSHOT')" ]; then
             echo "STATUS=snapshot" >> $GITHUB_ENV
@@ -84,14 +78,14 @@ jobs:
           fi
 
       - name: Publish snapshot to Sonatype
-        if: ${{ github.event_name == 'push' && env.STATUS != 'release' && startsWith(github.ref, 'refs/heads/nightly') && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') && matrix.java == 21 }}
+        if: ${{ github.event_name == 'push' && env.STATUS != 'release' && startsWith(github.ref, 'refs/heads/nightly') && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') }}
         run: ./gradlew publish
         env:
           SONATYPE_USER: "${{ secrets.SONATYPE_USER }}"
           SONATYPE_TOKEN: "${{ secrets.SONATYPE_TOKEN }}"
 
       - name: Prepare artifacts zip
-        if: ${{ github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') && matrix.java == 21 }}
+        if: ${{ github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') }}
         run: |
           mkdir -p temp/;
           mkdir -p temp/plugins;
@@ -104,7 +98,7 @@ jobs:
 
       - name: Upload artifacts zip
         uses: actions/upload-artifact@v4
-        if: ${{ github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') && matrix.java == 21 }}
+        if: ${{ github.event_name == 'push' && !startsWith(github.ref, 'refs/heads/gh-readonly-queue/') }}
         with:
           name: CloudNet
           path: temp/

.idea/inspectionProfiles/CloudNet.xml

@@ -7,5 +7,5 @@ IF %ERRORLEVEL% NEQ 0 (
   EXIT /b 1
 ) ELSE (
 :: DO NOT CHANGE THE SUPPLIED MEMORY HERE. THIS HAS NO EFFECT ON THE NODE INSTANCE. USE THE launcher.cnl INSTEAD
-  java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
+  java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -jar launcher.jar
 )

.template/start.bat

@@ -5,7 +5,7 @@ cd "$(dirname "$0")" || exit 1
 # check if java is installed
 if [ -x "$(command -v java)" ]; then
   # DO NOT CHANGE THE SUPPLIED MEMORY HERE. THIS HAS NO EFFECT ON THE NODE INSTANCE. USE THE launcher.cnl INSTEAD
-  java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
+  java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -jar launcher.jar
 else
   echo "No valid java installation was found, please install java in order to run CloudNet"
   exit 1

.template/start.command

@@ -8,10 +8,10 @@ if [ -x "$(command -v java)" ]; then
   # this check is elevated as tmux is sometimes present by default
   if [ -x "$(command -v screen)" ]; then
     # DO NOT CHANGE THE SUPPLIED MEMORY HERE. THIS HAS NO EFFECT ON THE NODE INSTANCE. USE THE launcher.cnl INSTEAD
-    screen -DRSq CloudNet java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
+    screen -DRSq CloudNet java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -jar launcher.jar
   elif [ -x "$(command -v tmux)" ]; then
     # DO NOT CHANGE THE SUPPLIED MEMORY HERE. THIS HAS NO EFFECT ON THE NODE INSTANCE. USE THE launcher.cnl INSTEAD
-    tmux new-session -As CloudNet java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -XX:+DisableExplicitGC -jar launcher.jar
+    tmux new-session -As CloudNet java -Xms128M -Xmx128M -XX:+UseZGC -XX:+PerfDisableSharedMem -jar launcher.jar
   else
     echo "No screen or tmux installation found, you need to install at least one of them to run CloudNet"
     exit 1

.template/start.sh

@@ -131,7 +131,7 @@ private fun resolveRepository(
   repositories: Iterable<MavenArtifactRepository>
 ): MavenArtifactRepository? {
   return repositories.firstOrNull {
-    val url = URL(it.url.toURL(), testUrlPath)
+    val url = it.url.resolve(testUrlPath).toURL()
     with(url.openConnection() as HttpURLConnection) {
       useCaches = false
       readTimeout = 30000

build-extensions/src/main/kotlin/extensions.kt

@@ -96,18 +96,29 @@ subprojects {
     testLogging {
       events("started", "passed", "skipped", "failed")
     }
+
+    // allow dynamic agent loading for mockito
+    jvmArgs(
+      "--enable-preview",
+      "-XX:+EnableDynamicAgentLoading",
+      "--add-opens=java.base/java.lang.invoke=ALL-UNNAMED"
+    )
+
     // always pass down all given system properties
     systemProperties(System.getProperties().mapKeys { it.key.toString() })
   }
 
   tasks.withType<JavaCompile>().configureEach {
-    sourceCompatibility = JavaVersion.VERSION_21.toString()
-    targetCompatibility = JavaVersion.VERSION_21.toString()
-    // options
+    sourceCompatibility = JavaVersion.VERSION_22.toString()
+    targetCompatibility = JavaVersion.VERSION_22.toString()
+
     options.encoding = "UTF-8"
     options.isIncremental = true
-    // we are aware that those are there, but we only do that if there is no other way we can use - so please keep the terminal clean!
-    options.compilerArgs = mutableListOf("-Xlint:-deprecation,-unchecked")
+
+    if (project.path != ":launcher:java8") {
+      options.compilerArgs.add("--enable-preview")
+      options.compilerArgs.add("-Xlint:-deprecation,-unchecked,-preview")
+    }
   }
 
   tasks.withType<Checkstyle> {

build.gradle.kts

@@ -224,7 +224,7 @@
     <module name="CatchParameterName">
       <message key="name.invalidPattern"
         value="Catch parameter name ''{0}'' must match pattern ''{1}''."/>
-      <property name="format" value="^[a-z]([a-z0-9][a-zA-Z0-9]*)?$"/>
+      <property name="format" value="^[a-z_]([a-z0-9][a-zA-Z0-9]*)?$"/>
     </module>
     <module name="LocalVariableName">
       <message key="name.invalidPattern"
@@ -332,7 +332,7 @@
     </module>
     <module name="SingleLineJavadoc"/>
     <module name="EmptyCatchBlock">
-      <property name="exceptionVariableName" value="ignored|expected"/>
+      <property name="exceptionVariableName" value="ignored|expected|_"/>
     </module>
     <module name="CommentsIndentation">
       <property name="tokens" value="SINGLE_LINE_COMMENT, BLOCK_COMMENT_BEGIN"/>

checkstyle.xml

@@ -63,6 +63,9 @@ public final class FileUtil {
       .filter(prov -> prov.getScheme().equalsIgnoreCase("jar"))
       .findFirst()
       .orElseThrow(() -> new ExceptionInInitializerError("Unable to find a file system provider supporting jars"));
+
+    // pre-create the temporary directory
+    FileUtil.createDirectory(TEMP_DIR);
   }
 
   private FileUtil() {

common/src/main/java/eu/cloudnetservice/common/io/FileUtil.java

@@ -30,19 +30,13 @@ tasks.withType<ShadowJar> {
 }
 
 tasks.withType<JavaCompile> {
-  options.compilerArgs = listOf("-AaerogelAutoFileName=autoconfigure/driver.aero")
+  options.compilerArgs.add("-AaerogelAutoFileName=autoconfigure/driver.aero")
 }
 
 tasks.withType<Test> {
   dependsOn(":common:jar")
 }
 
-extensions.configure<JavaPluginExtension> {
-  sourceSets {
-    create("ap")
-  }
-}
-
 dependencies {
   "api"(projects.common)
   "api"(projects.ext.updater)
@@ -67,8 +61,5 @@ dependencies {
   "implementation"(variantOf(libs.nettyNativeEpoll) { classifier("linux-x86_64") })
   "implementation"(variantOf(libs.nettyNativeEpoll) { classifier("linux-aarch_64") })
 
-  // hack - depend on the output of the ap output to apply the annotation process to this project too
-  "annotationProcessor"(project.sourceSets()["ap"].output)
-
   "testImplementation"(projects.common.dependencyProject.sourceSets()["main"].output)
 }