You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
The path argument for http.request needs to have the leading slash or the network request is invalid. The current code is misleading and results in errors, for example, in nginx logs similar to the following:
"GET health HTTP/1.1" 400 157 "-" "-" "-"
Currently PingCheck adds an extra slash to both the error message and call to super on the following lines:
This makes it seem like you shouldn't add the leading slash.
Additionally, as you can see from the nginx log output, a 400 error is returned in the situation I encountered, but this results in success in the current code path. I guess you could argue that a Ping check should just check connectivity, but it would at least be good to document the behavior in these types of error situations.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The
path
argument forhttp.request
needs to have the leading slash or the network request is invalid. The current code is misleading and results in errors, for example, in nginx logs similar to the following:Currently
PingCheck
adds an extra slash to both the error message and call tosuper
on the following lines:This makes it seem like you shouldn't add the leading slash.
Additionally, as you can see from the nginx log output, a 400 error is returned in the situation I encountered, but this results in success in the current code path. I guess you could argue that a Ping check should just check connectivity, but it would at least be good to document the behavior in these types of error situations.
The text was updated successfully, but these errors were encountered: