Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

PingCheck's path parameter requires leading slash #103

Open
tomi-bigpi opened this issue Jul 7, 2021 · 0 comments
Open

PingCheck's path parameter requires leading slash #103

tomi-bigpi opened this issue Jul 7, 2021 · 0 comments

Comments

@tomi-bigpi
Copy link

The path argument for http.request needs to have the leading slash or the network request is invalid. The current code is misleading and results in errors, for example, in nginx logs similar to the following:

"GET health HTTP/1.1" 400 157 "-" "-" "-"

Currently PingCheck adds an extra slash to both the error message and call to super on the following lines:

This makes it seem like you shouldn't add the leading slash.

Additionally, as you can see from the nginx log output, a 400 error is returned in the situation I encountered, but this results in success in the current code path. I guess you could argue that a Ping check should just check connectivity, but it would at least be good to document the behavior in these types of error situations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant