Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] All Contributors support #82

Closed
VeckoTheGecko opened this issue Mar 21, 2023 · 14 comments · Fixed by #84
Closed

[FEATURE] All Contributors support #82

VeckoTheGecko opened this issue Mar 21, 2023 · 14 comments · Fixed by #84
Labels
enhancement New feature or request for the website help wanted Extra attention is needed 🟢high priority A high priority feature

Comments

@VeckoTheGecko
Copy link
Collaborator

VeckoTheGecko commented Mar 21, 2023

Describe your suggested improvement
Better recognise contributors by using the all contributors bot.
https://allcontributors.org/

Surface either in README.md or perhaps in section on the website.

Would you be capable/willing to implement the improvement?
Yes Not without some help (#82 (comment))

@VeckoTheGecko VeckoTheGecko added the enhancement New feature or request for the website label Mar 21, 2023
@VeckoTheGecko
Copy link
Collaborator Author

Still buggy as per comments in #85 😢

@VeckoTheGecko VeckoTheGecko reopened this Mar 22, 2023
@azebramoomoo
Copy link

NOOOOOOOOO

@VeckoTheGecko
Copy link
Collaborator Author

Tried to debug, but at a loss as to whats happening. Posted all-contributors/app#460 and will now sideline this issue

@VeckoTheGecko
Copy link
Collaborator Author

VeckoTheGecko commented Mar 24, 2023

@Morzaram would you mind syncing your fork and trying this there?

ie.

  • install the all-contributors bot on your fork
  • make an issue in your fork, and type "@all-contributors please add @Morzaram for code" or some other usage
  • bot should reply in the issue

If it fails, it may be to do with the files in the repo and I can bugfix. If it succeeds, its a weird bug beyond our control as per the referenced issue just above and I'll shift focus.

No need for you to bugfix (its a headache lol)

@allcontributors

This comment was marked as off-topic.

@Morzaram
Copy link
Contributor

Morzaram commented Mar 25, 2023

@VeckoTheGecko Morzaram#1

Like this?

Seems to be working, but I changed the read me so it's exactly like it says in the docs regarding contributors section. Not sure if that's the issue or not

@VeckoTheGecko
Copy link
Collaborator Author

@Morzaram I dont think thats the issue. From what I see that doesn't change anything significant:
image

Thanks for testing :)

@Morzaram
Copy link
Contributor

Yea true! And no problem! Let me know if there's anything else I can do!

@VeckoTheGecko VeckoTheGecko added help wanted Extra attention is needed 🟢high priority A high priority feature labels May 9, 2023
@VeckoTheGecko VeckoTheGecko pinned this issue May 9, 2023
@VeckoTheGecko
Copy link
Collaborator Author

More people are starting to contribute to this project, and I would really like to get All Contributors up and running so that we can recognise contributions in the README.

My attempts to get this working have been frustrating and messy, encountering this strange bug #460. If anyone is able to suss out exactly what the problem is, that will allow us to get this up and running in this repo.

@VeckoTheGecko
Copy link
Collaborator Author

Fixed the bot! Turns out the problem was that we had a all-contributors branch in the repo which contflicted with the bot which uses the all-contributors/* namespace. -1 for uninformative bot error messages I guess 😂

@VeckoTheGecko
Copy link
Collaborator Author

@all-contributors
please add @VeckoTheGecko for maintenance, project management, ideas, coding, and content
please add @azebramoomoo for content, and design
please add @Jacobjeevan for code
please add @Morzaram for code
please add @JarrodBaniqued for content
please add @dmlb for accessibility
please add @tutterown for code and content
please add @GBT7 for content
please add @williamtaggart97 for ideas
please add @Micahg05 for code

@VeckoTheGecko
Copy link
Collaborator Author

Sorry for the repeated pings people 😢
@all-contributors
please add @VeckoTheGecko for maintenance, project management, ideas, coding, and content
please add @azebramoomoo for content, and design
please add @Jacobjeevan for code
please add @Morzaram for code
please add @JarrodBaniqued for content
please add @dmlb for accessibility
please add @tutterown for code and content
please add @GBT7 for content
please add @williamtaggart97 for ideas
please add @Micahg05 for code

@allcontributors
Copy link
Contributor

@VeckoTheGecko

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @VeckoTheGecko! 🎉

@azebramoomoo already contributed before to content, design

@Jacobjeevan already contributed before to code

@Morzaram already contributed before to code

@JarrodBaniqued already contributed before to content

We had trouble processing your request. Please try again later.

@allcontributors
Copy link
Contributor

@VeckoTheGecko

I've put up a pull request to add @VeckoTheGecko! 🎉

I've put up a pull request to add @azebramoomoo! 🎉

I've put up a pull request to add @Jacobjeevan! 🎉

I've put up a pull request to add @Morzaram! 🎉

I've put up a pull request to add @JarrodBaniqued! 🎉

I've put up a pull request to add @dmlb! 🎉

I've put up a pull request to add @tutterown! 🎉

I've put up a pull request to add @GBT7! 🎉

I've put up a pull request to add @williamtaggart97! 🎉

I've put up a pull request to add @Micahg05! 🎉

@VeckoTheGecko VeckoTheGecko unpinned this issue May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request for the website help wanted Extra attention is needed 🟢high priority A high priority feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants