diff --git a/src/scorm_package/scorm.py b/src/scorm_package/scorm.py index bf10814..a54be27 100644 --- a/src/scorm_package/scorm.py +++ b/src/scorm_package/scorm.py @@ -156,14 +156,13 @@ def zip_directory(dir_name): # logging the list of all files to be zipped logger.info('The following list of files will be zipped:') - for fileName in filePaths: - logger.info(fileName) # writing files to a zipfile - with zipfile.ZipFile(os.path.join(dir_name, dir_name + '.zip'), 'w') as zip_file: + with zipfile.ZipFile(dir_name + '.zip', 'w') as zip_file: # writing each file one by one for file_name in filePaths: arc_name = os.path.relpath(file_name, dir_name) + logger.info(f"{file_name}: {arc_name}") zip_file.write(file_name, arc_name) logger.info(f"{dir_name}.zip file was created successfully!") diff --git a/tests/test_scorm.py b/tests/test_scorm.py index 2f58a43..2e611aa 100644 --- a/tests/test_scorm.py +++ b/tests/test_scorm.py @@ -1,4 +1,4 @@ -from scorm_package.scorm import render_template, resourcelist +from scorm_package.scorm import render_template, resourcelist, retrieve_file_paths import os def test_template_render_organisations(): @@ -67,4 +67,4 @@ def test_resource_list(): actual = resourcelist(os.path.join('tests', 'fixtures', 'resourcelist')) expected = ['res/1.html', 'res/2.html', 'res/3.html'] - assert actual == expected \ No newline at end of file + assert actual == expected