Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot invalidate_hard_deletes feature #291

Open
dstsimokha opened this issue Jun 9, 2024 · 1 comment
Open

snapshot invalidate_hard_deletes feature #291

dstsimokha opened this issue Jun 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dstsimokha
Copy link
Contributor

Is your feature request related to a problem? Please describe.
invalidate_hard_deletes=True for snapshots not working with CH because of its default non-nullable column

Describe the solution you'd like
dbt general default__snapshot_staging_table macro can be modified in two places by changing {{ strategy.unique_key }} to toNullable({{ strategy.unique_key }}) - in snapshotted_data and deletes_source_data CTEs
@dstsimokha dstsimokha added the enhancement New feature or request label Jun 9, 2024
@rjoelnorgren
Copy link
Contributor

I was able to workaround this by specifying query_settings={"join_use_nulls": 1} in the snapshot config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dstsimokha @rjoelnorgren