Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing releases #34

Open
dzeban opened this issue Mar 22, 2019 · 1 comment
Open

Publishing releases #34

dzeban opened this issue Mar 22, 2019 · 1 comment

Comments

@dzeban
Copy link

dzeban commented Mar 22, 2019

Hi, Yegor

I wanted to propose the automatic releasing of clickhouse_exporter as it's what people (including me) really want (see, for example, #32). This will make installation of clickhouse_exporter via config management tools very simple, e.g. I could finally add to my Ansible role downloading of clickhouse_exporter from GitHub.

This can be achieved with promu release but it requires creating the release in Github. Which in turn can be made by invoking github-release but all of that seems overly complicated.

So instead I want to rework the building and CI a little bit, namely:

  • Remove promu dependency because I don't see why it's needed. It's used only with build command in Makefile but the project is built in the previous line of Makefile with go install.
  • Fix Makefile to test all packages with ./.... Currently, it doesn't invoke any tests because main package doesn't have any.
  • Add goreleaser support to automate releases.
  • Rework Travis configuration:
    • Invoke make test to actually run tests on PRs
    • Create release with goreleaser when tag is pushed. This will create downloadable artifacts for multitude of operating systems and architectures. Even deb and rpm packages can be built!

Let me know what you think because maybe I'm missing something and I'm completely wrong and shouldn't do this.

Thanks!

@kormotodor
Copy link

I think it is better to use your fork) Thank you for the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants