Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and split set_precomputed_quantities! #270

Open
Tracked by #2632
charleskawczynski opened this issue Oct 6, 2023 · 1 comment
Open
Tracked by #2632

Rename and split set_precomputed_quantities! #270

charleskawczynski opened this issue Oct 6, 2023 · 1 comment
Assignees
@charleskawczynski
Labels
Performance
Milestone
O1.2.5 1 SYPD for...

Comments

@charleskawczynski
Copy link
Member

Now that ClimaTimeSteppers has post_explicit! and post_implicit! hooks, we should probably rename set_precomputed_quantities! to something that better matches the hooks. In addition, post_implicit! only needs to compute terms needed in explicit kernels, and not in implicit kernels, so we can likely eliminate unnecessary computations there.
@charleskawczynski charleskawczynski mentioned this issue Feb 13, 2024
Open
@charleskawczynski
Copy link
Member Author

I think this may be handled in #264.

@charleskawczynski charleskawczynski transferred this issue from CliMA/ClimaAtmos.jl Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleskawczynski charleskawczynski

Labels
Performance
Projects
None yet
Milestone
O1.2.5 1 SYPD for AMIP
Development

No branches or pull requests
1 participant
@charleskawczynski