Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async T_exp! and T_lim! #247

Closed
Tracked by #2632
charleskawczynski opened this issue Feb 9, 2024 · 1 comment
Closed
Tracked by #2632

Add support for async T_exp! and T_lim! #247

charleskawczynski opened this issue Feb 9, 2024 · 1 comment

Comments

@charleskawczynski
Copy link
Member

We can compute T_exp! and T_lim! asynchronously to improve performance. #229 does this using @async, but Simon mentioned that this is perhaps not the best option and there is a warning about @async in the Julia docs:

  │ Warning
  │
  │  It is strongly encouraged to favor Threads.@spawn over @async always even when no parallelism is required especially in publicly distributed
  │  libraries. This is because a use of @async disables the migration of the parent task across worker threads in the current implementation of Julia.
  │  Thus, seemingly innocent use of @async in a library function can have a large impact on the performance of very different parts of user applications.

Tim Besard discusses this in https://www.youtube.com/watch?v=fw0R5G8pB0U. I'm going to have a second look at this to see what's the right way to leverage parallelism/concurrency, since we'll probably want similar or the same solution in #233.

@charleskawczynski
Copy link
Member Author

We're going to fuse these function instead, so that we can reduce the number of DSS calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant