Define allowscalar #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
requested review from
Sbozzolo,
juliasloan25,
sriharshakandala and
AlexisRenchon
Sbozzolo
reviewed
Jun 5, 2024
Yes, absolutely. |
charleskawczynski
force-pushed
the
ck/device_methods
branch
from
b7c63be
to
f14e921
Compare
charleskawczynski
force-pushed
the
ck/device_methods
branch
from
f14e921
to
8ad2496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines an
allowscalarmethod, that provides a device-agnostic way to useCUDA.@allowscalar.This should help us remove CUDA as a dependency in the ClimaCore test suite.