Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define device-agnostic fill #81

Closed
wants to merge 1 commit into from
Closed

Define device-agnostic fill #81

wants to merge 1 commit into from

Conversation

charleskawczynski
Copy link
Member

Followup to #80.

@Sbozzolo
Copy link
Member

Sbozzolo commented Jun 6, 2024

Where is this needed? Maybe it can be fixed downstream by using ClimaComms.array_type and Base.fill!. This is in the spirit of avoiding to reimplement all the functions in ClimaComms

@charleskawczynski
Copy link
Member Author

Where is this needed? Maybe it can be fixed downstream by using ClimaComms.array_type and Base.fill!. This is in the spirit of avoiding to reimplement all the functions in ClimaComms

I do think that this is the last one that we're actually using. It's used in the ClimaCore test suite, I'm fine with skipping and using array_type/fill!. I don't want to extend a device-agnostic version of every method in CUDA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Awaiting requested review from Sbozzolo

@sriharshakandala sriharshakandala Awaiting requested review from sriharshakandala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @Sbozzolo