You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think Application.updateTag() should be renamed Application.addTag() to match Addon.addTag() as both function have the same role on different models and both make a PUT call to the API.
To fix this, you could introduce an alias so it doesn't impact people already using Application.updateTag().
The other function matches on removeTag and getAllTags. replaceAddonTags is only present on Addon which is kind of wierd, it should be named replaceTags and present in Application for the same purpose.
The text was updated successfully, but these errors were encountered:
I think
Application.updateTag()
should be renamedApplication.addTag()
to matchAddon.addTag()
as both function have the same role on different models and both make aPUT
call to the API.To fix this, you could introduce an alias so it doesn't impact people already using
Application.updateTag()
.The other function matches on
removeTag
andgetAllTags
.replaceAddonTags
is only present onAddon
which is kind of wierd, it should be namedreplaceTags
and present inApplication
for the same purpose.The text was updated successfully, but these errors were encountered: