Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag functions inconsistencies between Addon and Application #58

Open
auguster opened this issue Feb 21, 2022 · 0 comments
Open

Tag functions inconsistencies between Addon and Application #58

auguster opened this issue Feb 21, 2022 · 0 comments

Comments

@auguster
Copy link

I think Application.updateTag() should be renamed Application.addTag() to match Addon.addTag() as both function have the same role on different models and both make a PUT call to the API.

To fix this, you could introduce an alias so it doesn't impact people already using Application.updateTag().

The other function matches on removeTag and getAllTags. replaceAddonTags is only present on Addon which is kind of wierd, it should be named replaceTags and present in Application for the same purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant