Skip to content
This repository has been archived by the owner on Jun 19, 2019. It is now read-only.

Better errors and warnings #3

Open
cloudkite opened this issue Nov 8, 2013 · 2 comments
Open

Better errors and warnings #3

cloudkite opened this issue Nov 8, 2013 · 2 comments

Comments

@cloudkite
Copy link
Contributor

For unrecognised properties, classes, arguments etc
At the moment some things are silently ignored.

@olegam
Copy link
Contributor

olegam commented Apr 30, 2014

I often experience that the stylesheet silently fails to parse when I have a syntax error. Nothing in the console, but no style applied. Is this intended?

How would you go about improving error handling? I have some time next weekend that I could spend on this issue.

@cloudkite
Copy link
Contributor Author

There are already some cases which are handled by the parser returning an NSError see
https://github.com/cloudkite/Classy/blob/master/Classy/Parser/CASParser.m#L274

So it would be a matter of checking those are working correctly, theres no tests around error handling at the moment. Then using the same approach to raise other errors. If you do have time to look into it, feel free to ping me with questions. thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants