-Wframe-larger-than= in fs/select.c

[nickdesaulniers]

  CC      kernel/task_work.o
fs/select.c:926:12: warning: stack frame size of 1064 bytes in function 'do_sys_poll' [-Wframe-larger-than=]
static int do_sys_poll(struct pollfd __user *ufds, unsigned int nfds,
           ^
1 warning generated.

This is not a duplicate of #39; CONFIG_KASAN is not set.

[nathanchance]

Hmmm this is x86_64? CONFIG_FRAME_WARN should be 2048 if CONFIG_64BIT is set.

[nickdesaulniers]

ah, I'll bet that my leftover localmodconfig has the old values.

[nathanchance]

s/isn't/is/, whoops lol. It's 1024 if CONFIG_64BIT isn't set.

[nathanchance]

I see this on arm32 (multi_v7_defconfig):

fs/select.c:594:5: warning: stack frame size of 1064 bytes in function 'core_sys_select' [-Wframe-larger-than=]
int core_sys_select(int n, fd_set __user *inp, fd_set __user *outp,
    ^
1 warning generated.

[bulwahn]

I have seen these two:

fs/select.c:619:5: warning: stack frame size of 1224 bytes in function 'core_sys_select' [-Wframe-larger-than=]
int core_sys_select(int n, fd_set __user *inp, fd_set __user *outp,
    ^
fs/select.c:965:12: warning: stack frame size of 1048 bytes in function 'do_sys_poll' [-Wframe-larger-than=]
static int do_sys_poll(struct pollfd __user *ufds, unsigned int nfds,
           ^
2 warnings generated.

on v5.1-rc5 with x86-64 allnoconfig + 64-bit kernel.

[nickdesaulniers]

I no longer see these w/ x86 (asm goto patches applied)