[BUGFIX] Fix for game crashing with any leader den outsider interaction #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, this function was expecting a tuple but the entire_supply property returns a dict, causing the random crash. By adding the items method the dictionary returns a tuple.
Fixed the name change for the outsider actions causing a crash. Fixed interactions with lost cats by .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixed the game crashing on any interaction with outisders, but reverting the name of the actions to pre-localization.
Fixed interactions with lost cats specifically. They probably broke when the change to keep track of the previous status in the clan was introduced. The game was checking if their status was "lost" and failing, because the lost status is now determined by the boolean cat.outside. So in the check status function, I added a conditional that compares the required lost status with this boolean.
Linked Issues
Fixes: #3379
Fixes: #3192
Proof of Testing
Changelog/Credits
[BUGFIX]: Fixed crash related to leader den interactions with outsiders