Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit usage of commands leading to direct database hits #223

Open
ProgrammerDan opened this issue Sep 1, 2016 · 2 comments
Open

Limit usage of commands leading to direct database hits #223

ProgrammerDan opened this issue Sep 1, 2016 · 2 comments

Comments

@ProgrammerDan
Copy link

Eliminate with prejudice, or at the very least rate limit its use.

@Maxopoly
Copy link

Maxopoly commented Sep 1, 2016

This doesn't apply only for nllm specifically, I only used it as an example. It's rather group managers behavior, where it will always attempt to load a group from the database, if it cant be found in the cache, so any commands with bogus group names will force a lookup in the db.

@ProgrammerDan
Copy link
Author

Oh, well, failure to find is very lightweight. I thought from what you said that giving it a valid group name would force a recache.

I'm not very concerned about bogus data causing cache hits and DB checks, those are pretty fast. Still not a bad idea to rate limit though...

@Maxopoly Maxopoly changed the title /nllm forces recache Limit usage of commands leading to direct database hits Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants