Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of configurable labels is a regression #3

Open
ProgrammerDan opened this issue Apr 8, 2016 · 0 comments
Open

Removal of configurable labels is a regression #3

ProgrammerDan opened this issue Apr 8, 2016 · 0 comments

Comments

@ProgrammerDan
Copy link

No good reason to have pulled them out, loses a lot of functionality that way.

Perhaps a consequence of moving to CivModCore with its sub-par configuration parsing?

Either way, it's a regression.
ProgrammerDan added a commit that referenced this issue Sep 8, 2016
@ProgrammerDan
Addressing #3 by adding a timeout-based reservation. Could be improve…
28c7104 
…d to tie to a timeout on the actual reply conversation, but this is good for now. Also introduces a conversation canceller that handles releasing the reservation on cancel, in addition to other typical releases such as error or actual answer provided. Ignore also briefly reserves and releases. Reserve is synchronized against rare contention edge case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ProgrammerDan